Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Console logs #846

Merged
merged 25 commits into from
Dec 17, 2024
Merged
Changes from 1 commit
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
99d583f
start progress on enhanced logging
maciekstosio Dec 12, 2024
2774a0e
Fix cdp function call
maciekstosio Dec 12, 2024
8b85e6e
working solution
maciekstosio Dec 12, 2024
a491868
clean code
maciekstosio Dec 12, 2024
089cdd1
clean code
maciekstosio Dec 12, 2024
6254b61
chore: remove old solution
maciekstosio Dec 12, 2024
9205918
chore: run prettier
maciekstosio Dec 12, 2024
3c9404e
chore: fix TS
maciekstosio Dec 12, 2024
b8038d7
Update typecheck-extension.yml
maciekstosio Dec 13, 2024
3aa90e2
Revert submodules checkout
maciekstosio Dec 13, 2024
2724c81
Update typecheck-extension.yml
maciekstosio Dec 13, 2024
c2c0e78
Update typecheck-extension.yml
maciekstosio Dec 13, 2024
e131888
chore: setup pipeline with vscode-js-debug
maciekstosio Dec 16, 2024
ff0d0bb
chore: improve setup
maciekstosio Dec 16, 2024
ca9f05e
chore: fix pipeline
maciekstosio Dec 16, 2024
2f91513
chore: fix lint
maciekstosio Dec 16, 2024
016ee46
chore: add git submodule update so user don't need to do it manually
maciekstosio Dec 16, 2024
19eaf6f
Update DebugAdapter.ts
maciekstosio Dec 16, 2024
1a115ac
Remove unused flag
maciekstosio Dec 16, 2024
b755418
chore: filter out primitives from collapsed args
maciekstosio Dec 17, 2024
4c31aaf
chore: don't display named arguments when orignally there was just on…
maciekstosio Dec 17, 2024
57750e9
chore: remove unnecessary file + improve comments
maciekstosio Dec 17, 2024
21e4c4f
chore: replace npx with npm exec and run lint
maciekstosio Dec 17, 2024
5c1db41
chore: refactore and add comment
maciekstosio Dec 17, 2024
dd5effe
Update packages/vscode-extension/src/debugging/DebugAdapter.ts
maciekstosio Dec 17, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: don't display named arguments when orignally there was just on…
…e argument
maciekstosio committed Dec 17, 2024
commit 4c31aafd92b2585a5386dba99e47eff87c618f53
5 changes: 5 additions & 0 deletions packages/vscode-extension/src/debugging/DebugAdapter.ts
Original file line number Diff line number Diff line change
@@ -250,6 +250,11 @@ export class DebugAdapter extends DebugSession {
// collapsed args properly, the object references the array of args array
const argsObjectDapID = this.variableStore.pushReplVariable(prepareVariables);

// If originally there was only one argument, we don't want to display named arguments
if (args.length === 1) {
return argsObjectDapID;
}

return this.variableStore.pushReplVariable([
{
name: "<unnamed>",