Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Source Request as for debug adapter protocol standard #945

Merged

Conversation

filip131311
Copy link
Collaborator

@filip131311 filip131311 commented Feb 10, 2025

This PR implements SourceRequest in debug adapter, it is not not currently in use but might be necessary in the future, if we ever get generated source on the extension side. For example we now in the inspector tool we now use the information about the source of component usage, but some future features like react-scan might require us to use information about component definition source and the only way to achieve that is to analise the component stackTrace, which points to generated location.

How Has This Been Tested:

-run expo-52-eas
-run react-native-78
-the change does not break any of the applications

Copy link

vercel bot commented Feb 10, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
radon-ide ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 10, 2025 0:48am

Copy link
Member

@kmagiera kmagiera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks ok, but I don't understand the description. Can you clarify what it is used for and how, in the future, we can use this code or test it when it becomes relevant?

@filip131311 filip131311 merged commit 9a2b6c8 into main Feb 17, 2025
4 checks passed
@filip131311 filip131311 deleted the @Filip131311/ImplementSourceRequestAsForDAPSpecification branch February 17, 2025 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants