@jakmro/classification android #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakmro
force-pushed
the
@jakmro/classification-android
branch
from
c0e021e to
e653737
Compare
mkopcins
requested changes
Dec 16, 2024
mkopcins
reviewed
Dec 17, 2024
| } | ||
|
|
||
| override fun preprocess(input: Mat): EValue { | ||
| Imgproc.resize(input, input, getModelImageSize()) |
There was a problem hiding this comment.
FYI this is not 'in-place' wrt underlying memory
mkopcins
approved these changes
Dec 17, 2024
chmjkb
pushed a commit
that referenced
this pull request
Dec 17, 2024
## Description Image classification for android ### Type of change - [ ] Bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Documentation update (improves or adds clarity to existing documentation) ### Tested on - [ ] iOS - [x] Android ### Checklist - [x] I have performed a self-review of my code - [x] I have commented my code, particularly in hard-to-understand areas - [ ] I have updated the documentation accordingly - [x] My changes generate no new warnings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Image classification for android
Type of change
Tested on
Checklist