Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore:refactor ts cv hooks #64

Merged
merged 10 commits into from
Dec 18, 2024
Merged

chore:refactor ts cv hooks #64

merged 10 commits into from
Dec 18, 2024

Conversation

mkopcins
Copy link
Collaborator

Description

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (improves or adds clarity to existing documentation)

Tested on

  • iOS
  • Android

Testing instructions

Screenshots

Related issues

Checklist

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly
  • My changes generate no new warnings

Additional notes

@mkopcins mkopcins changed the title @mkopcins/ts code refactor chore:refactor ts cv hooks Dec 18, 2024
chmjkb
chmjkb reviewed Dec 18, 2024
View reviewed changes
Copy link
Contributor

@chmjkb chmjkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we maybe somehow use ETModule.ts for this?

src/types/types.ts Outdated Show resolved Hide resolved
src/types/object_detection_types.ts Outdated Show resolved Hide resolved
src/useModule.ts Outdated Show resolved Hide resolved
Mateusz Kopcinski and others added 3 commits December 18, 2024 12:35
@mkopcins mkopcins merged commit 69802ee into main Dec 18, 2024
2 checks passed
@mkopcins mkopcins deleted the @mkopcins/ts-code-refactor branch December 18, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chmjkb chmjkb chmjkb approved these changes

@NorbertKlockiewicz NorbertKlockiewicz Awaiting requested review from NorbertKlockiewicz

@jakmro jakmro Awaiting requested review from jakmro

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mkopcins @chmjkb