fix: Break circular reference in LayoutAnimation
#6671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomekzaw
approved these changes
Nov 6, 2024
tjzel
reviewed
Dec 24, 2024
| @@ -110,6 +110,8 @@ NativeProxy::~NativeProxy() { | |||
| // has already been destroyed when AnimatedSensorModule's | |||
| // destructor is ran | |||
| nativeReanimatedModule_->cleanupSensors(); | |||
|
|
|||
| layoutAnimations_->cthis()->invalidate(); | |||
There was a problem hiding this comment.
I've been dealing a lot with missing invalidations in #6850 and I have some thoughts.
Shouldn't we call it from Java when Native Modules are invalidated, for a more transparent flow?
(java)ReanimatedModule.invalidate() -> ... -> (java)NativeProxy.invalidate() -> (hybrid)LayoutAnimations->invalidate()
I don't think that relying on Native Proxy's destructor is the best choice here. On the other hand, this is safer since NativeProxy can be "safely" used until it's destroyed.
What do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Breaks circular reference in the
LayoutAnimations.LayoutAnimationsis aHybridClasswith a C++ counterpart holding a global reference to the Java object. This structure creates a circular reference between C++ and Java, which the garbage collector cannot clean up. To resolve this issue, I manually removed the reference between C++ and Java by resetting the global ref during the destructor of theNativeProxy.Test plan