feature: Detect edge-to-edge and set isStatusBarTranslucentAndroid / isNavigationBarTranslucentAndroid #6732
+32
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @zoontek, thanks for this PR. We briefly discussed this internally and @bartlomiejbloniarz will take a look on it. |
3 tasks
|
@tomekzaw @bartlomiejbloniarz Any news? It continues to create hard to detect issues. |
|
Hi @zoontek. I changed the version of |
|
@bartlomiejbloniarz Sure, no worry 🙂 |
zoontek
force-pushed
the
detect-edge-to-edge
branch
from
e04f041 to
5d91625
Compare
|
@bartlomiejbloniarz I rebased against main to fix the conflict. |
bartlomiejbloniarz
approved these changes
Jan 10, 2025
tomekzaw
approved these changes
Jan 10, 2025
piaskowyk
approved these changes
Jan 10, 2025
tjzel
reviewed
Jan 10, 2025
|
@bartlomiejbloniarz @tjzel Note that if it's blocking for you to add a dependency, we can also just inline the check and remove the dep. This is super lightweight, no dependencies, but also no control / warnings.
|
8 tasks
|
Don't worry @zoontek. I looked into the packages code and I understood the context more and I think there won't be problems even if there are multiple versions loaded in. |
|
Currently we are freezing the main branch for maintenance reasons so it will land there a bit later. |
…isNavigationBarTranslucentAndroid # Conflicts: # packages/react-native-reanimated/src/core.ts # Conflicts: # yarn.lock
zoontek
force-pushed
the
detect-edge-to-edge
branch
from
5d91625 to
bde185f
Compare
|
I rebased against |
Closed
3 tasks
tjzel
pushed a commit
that referenced
this pull request
Feb 24, 2025
…isNavigationBarTranslucentAndroid (#6732) ## Summary Similar to [the PR](software-mansion/react-native-screens#2464) I opened on the `react-native-screens` repository (I highly recommend to read the discussion there to understand the motivation behind this), this PR detects if the user enabled edge-to-edge and act accordingly: `useAnimatedKeyboard` are ignored, set to `true` automatically. If those are set, a warning is logged: > `isStatusBarTranslucentAndroid` and `isNavigationBarTranslucentAndroid` values are ignored when `using react-native-edge-to-edge` It at some point [this proposal](facebook/react-native#47554) lands in core, `react-native-is-edge-to-edge` will be updated to support both the library and the core edge-to-edge flag, making the transition seamless for the users. ## Test plan - Install [react-native-edge-to-edge](https://github.com/zoontek/react-native-edge-to-edge) in the example app. - Don't set `isStatusBarTranslucentAndroid` / `isNavigationBarTranslucentAndroid`, or set them to something else than `true` --------- Co-authored-by: Bartłomiej Błoniarz <[email protected]>
tjzel
pushed a commit
that referenced
this pull request
Feb 24, 2025
…isNavigationBarTranslucentAndroid (#6732) ## Summary Similar to [the PR](software-mansion/react-native-screens#2464) I opened on the `react-native-screens` repository (I highly recommend to read the discussion there to understand the motivation behind this), this PR detects if the user enabled edge-to-edge and act accordingly: `useAnimatedKeyboard` are ignored, set to `true` automatically. If those are set, a warning is logged: > `isStatusBarTranslucentAndroid` and `isNavigationBarTranslucentAndroid` values are ignored when `using react-native-edge-to-edge` It at some point [this proposal](facebook/react-native#47554) lands in core, `react-native-is-edge-to-edge` will be updated to support both the library and the core edge-to-edge flag, making the transition seamless for the users. ## Test plan - Install [react-native-edge-to-edge](https://github.com/zoontek/react-native-edge-to-edge) in the example app. - Don't set `isStatusBarTranslucentAndroid` / `isNavigationBarTranslucentAndroid`, or set them to something else than `true` --------- Co-authored-by: Bartłomiej Błoniarz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Similar to the PR I opened on the
react-native-screensrepository (I highly recommend to read the discussion there to understand the motivation behind this), this PR detects if the user enabled edge-to-edge and act accordingly:useAnimatedKeyboardare ignored, set totrueautomatically. If those are set, a warning is logged:It at some point this proposal lands in core,
react-native-is-edge-to-edgewill be updated to support both the library and the core edge-to-edge flag, making the transition seamless for the users.Test plan
isStatusBarTranslucentAndroid/isNavigationBarTranslucentAndroid, or set them to something else thantrue