Develop benchmarks #951
Draft
Develop benchmarks #951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am wondering what kind of resolution presets use to be meaningful and unambiguous. Maybe rename it to sth like pub enum ResolutionPreset {
Uhd,
Qhd,
Fhd,
Hd,
Sd,
} |
jerzywilczek
reviewed
Feb 5, 2025
Comment on lines
+104
to
+110
| pub enum ResolutionPreset { | ||
| Uhd, | ||
| Qhd, | ||
| Fhd, | ||
| Hd, | ||
| Sd, | ||
| } |
There was a problem hiding this comment.
I think it would be cool if the only thing you specified on the cmd was the number ++ p: --resolution 1080p. I would hate if you had to specify the resolution like this: --resolution res_480_p.
Also, derive(ValueEnum) does nothing here I think, since you implement parsing manually anyway.
| #[derive(Debug, Clone, Copy)] | ||
| pub enum ResolutionConstant { | ||
| Preset(ResolutionPreset), | ||
| Value(u32, u32), |
There was a problem hiding this comment.
Suggested change
| Value(u32, u32), | |
| Value(Resolution), |
That's how I'd do it, but it's up to you
| pub encoder_preset: EncoderPreset, | ||
| pub disable_encoder: bool, | ||
|
|
||
| #[arg(long, global = true, required_unless_present("disable_encoder"))] |
There was a problem hiding this comment.
We don't need global here, as we don't have subcommands.
Also, you can use default_value instead of Option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for issue #937
Develop more benchmark options:
resolution
outputs
run without encoder
run without decoder
renamed
encoder/decoder_counttooutput/input_countto be more meaningful