Bump the dev-dependencies group with 13 updates (#1251)

* Bump the dev-dependencies group with 13 updates Bumps the dev-dependencies group with 13 updates: | Package | From | To | | --- | --- | --- | | [pytest](https://github.com/pytest-dev/pytest) | `7.4.0` | `7.4.4` | | [black](https://github.com/psf/black) | `23.7.0` | `23.12.1` | | [poethepoet](https://github.com/nat-n/poethepoet) | `0.22.0` | `0.24.4` | | [coverage](https://github.com/nedbat/coveragepy) | `7.3.0` | `7.4.0` | | [pytest-asyncio](https://github.com/pytest-dev/pytest-asyncio) | `0.21.1` | `0.23.3` | | [pylint](https://github.com/pylint-dev/pylint) | `2.17.5` | `3.0.3` | | [setuptools](https://github.com/pypa/setuptools) | `68.1.2` | `69.0.3` | | [pytest-mock](https://github.com/pytest-dev/pytest-mock) | `3.11.1` | `3.12.0` | | [pytest-xdist](https://github.com/pytest-dev/pytest-xdist) | `3.3.1` | `3.5.0` | | [pyright](https://github.com/RobertCraigie/pyright-python) | `1.1.325` | `1.1.345` | | [isort](https://github.com/pycqa/isort) | `5.12.0` | `5.13.2` | | [pytest-rerunfailures](https://github.com/pytest-dev/pytest-rerunfailures) | `12.0` | `13.0` | | [cairo-lang](https://github.com/starkware-libs/cairo-lang) | `0.12.2` | `0.13.0` | Updates `pytest` from 7.4.0 to 7.4.4 - [Release notes](https://github.com/pytest-dev/pytest/releases) - [Changelog](https://github.com/pytest-dev/pytest/blob/main/CHANGELOG.rst) - [Commits](pytest-dev/pytest@7.4.0...7.4.4) Updates `black` from 23.7.0 to 23.12.1 - [Release notes](https://github.com/psf/black/releases) - [Changelog](https://github.com/psf/black/blob/main/CHANGES.md) - [Commits](psf/black@23.7.0...23.12.1) Updates `poethepoet` from 0.22.0 to 0.24.4 - [Release notes](https://github.com/nat-n/poethepoet/releases) - [Commits](nat-n/poethepoet@v0.22.0...v0.24.4) Updates `coverage` from 7.3.0 to 7.4.0 - [Release notes](https://github.com/nedbat/coveragepy/releases) - [Changelog](https://github.com/nedbat/coveragepy/blob/master/CHANGES.rst) - [Commits](nedbat/coveragepy@7.3.0...7.4.0) Updates `pytest-asyncio` from 0.21.1 to 0.23.3 - [Release notes](https://github.com/pytest-dev/pytest-asyncio/releases) - [Commits](pytest-dev/pytest-asyncio@v0.21.1...v0.23.3) Updates `pylint` from 2.17.5 to 3.0.3 - [Release notes](https://github.com/pylint-dev/pylint/releases) - [Commits](pylint-dev/pylint@v2.17.5...v3.0.3) Updates `setuptools` from 68.1.2 to 69.0.3 - [Release notes](https://github.com/pypa/setuptools/releases) - [Changelog](https://github.com/pypa/setuptools/blob/main/NEWS.rst) - [Commits](pypa/setuptools@v68.1.2...v69.0.3) Updates `pytest-mock` from 3.11.1 to 3.12.0 - [Release notes](https://github.com/pytest-dev/pytest-mock/releases) - [Changelog](https://github.com/pytest-dev/pytest-mock/blob/main/CHANGELOG.rst) - [Commits](pytest-dev/pytest-mock@v3.11.1...v3.12.0) Updates `pytest-xdist` from 3.3.1 to 3.5.0 - [Release notes](https://github.com/pytest-dev/pytest-xdist/releases) - [Changelog](https://github.com/pytest-dev/pytest-xdist/blob/master/CHANGELOG.rst) - [Commits](pytest-dev/pytest-xdist@v3.3.1...v3.5.0) Updates `pyright` from 1.1.325 to 1.1.345 - [Release notes](https://github.com/RobertCraigie/pyright-python/releases) - [Commits](RobertCraigie/pyright-python@v1.1.325...v1.1.345) Updates `isort` from 5.12.0 to 5.13.2 - [Release notes](https://github.com/pycqa/isort/releases) - [Changelog](https://github.com/PyCQA/isort/blob/main/CHANGELOG.md) - [Commits](PyCQA/isort@5.12.0...5.13.2) Updates `pytest-rerunfailures` from 12.0 to 13.0 - [Changelog](https://github.com/pytest-dev/pytest-rerunfailures/blob/master/CHANGES.rst) - [Commits](pytest-dev/pytest-rerunfailures@12.0...13.0) Updates `cairo-lang` from 0.12.2 to 0.13.0 - [Release notes](https://github.com/starkware-libs/cairo-lang/releases) - [Commits](starkware-libs/cairo-lang@v0.12.2...v0.13.0) --- updated-dependencies: - dependency-name: pytest dependency-type: direct:development update-type: version-update:semver-patch dependency-group: dev-dependencies - dependency-name: black dependency-type: direct:development update-type: version-update:semver-minor dependency-group: dev-dependencies - dependency-name: poethepoet dependency-type: direct:development update-type: version-update:semver-minor dependency-group: dev-dependencies - dependency-name: coverage dependency-type: direct:development update-type: version-update:semver-minor dependency-group: dev-dependencies - dependency-name: pytest-asyncio dependency-type: direct:development update-type: version-update:semver-minor dependency-group: dev-dependencies - dependency-name: pylint dependency-type: direct:development update-type: version-update:semver-major dependency-group: dev-dependencies - dependency-name: setuptools dependency-type: direct:development update-type: version-update:semver-major dependency-group: dev-dependencies - dependency-name: pytest-mock dependency-type: direct:development update-type: version-update:semver-minor dependency-group: dev-dependencies - dependency-name: pytest-xdist dependency-type: direct:development update-type: version-update:semver-minor dependency-group: dev-dependencies - dependency-name: pyright dependency-type: direct:development update-type: version-update:semver-patch dependency-group: dev-dependencies - dependency-name: isort dependency-type: direct:development update-type: version-update:semver-minor dependency-group: dev-dependencies - dependency-name: pytest-rerunfailures dependency-type: direct:development update-type: version-update:semver-major dependency-group: dev-dependencies - dependency-name: cairo-lang dependency-type: direct:development update-type: version-update:semver-minor dependency-group: dev-dependencies ... Signed-off-by: dependabot[bot] <[email protected]> * revert pytest-asyncio to ^0.21.1 beacause of changes in the context of event_loop * update hash * fix lint * fix linter * Add issue id to TODO * fix imports * format * downgrade pyright version * Update pyproject.toml Co-authored-by: ddoktorski <[email protected]> * fix * adds to many arguments * adds pylint: disable=too-many-arguments * Update starknet_py/net/account/account.py Co-authored-by: ddoktorski <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: tkumor3 <[email protected]> Co-authored-by: ddoktorski <[email protected]>
software-mansion · Feb 6, 2024 · 336e0f2 · 336e0f2
1 parent e26efe2
commit 336e0f2
Show file tree

Hide file tree

Showing 14 changed files with 160 additions and 260 deletions.
diff --git a/.pylintrc b/.pylintrc
@@ -543,7 +543,7 @@ exclude-too-few-public-methods=
 ignored-parents=
 
 # Maximum number of arguments for function / method.
-max-args=5
+max-args=6
 
 # Maximum number of attributes for a class (see R0902).
 max-attributes=7

diff --git a/poetry.lock b/poetry.lock
diff --git a/pylint_todo_checker.py b/pylint_todo_checker.py
@@ -13,9 +13,7 @@ def register(linter: "PyLinter") -> None:
     linter.register_checker(TodoTokenChecker(linter))
 
 
-class TodoTokenChecker(checkers.BaseChecker):
-    __implements__ = interfaces.ITokenChecker
-
+class TodoTokenChecker(checkers.BaseTokenChecker):
     name = "todo-issue-error"
     priority = -1
     msgs = {

diff --git a/pyproject.toml b/pyproject.toml
@@ -35,22 +35,22 @@ docs = ["sphinx", "enum-tools", "furo"]
 [tool.poetry.group.dev.dependencies]
 pytest = "^7.2.2"
 black = "^23.1.0"
-poethepoet = "^0.22.0"
+poethepoet = "^0.24.4"
 coverage = "^7.2.1"
 pytest-asyncio = "^0.21.1"
-pylint = "2.17.5"
-setuptools = "^68.0.0"
+pylint = "3.0.3"
+setuptools = "^69.0.3"
 pytest-mock = "^3.6.1"
 pytest-xdist = "^3.2.1"
-pyright = "^1.1.298"
+pyright = "1.1.338"
 pytest-cov = "^4.0.0"
 isort = "^5.11.4"
-pytest-rerunfailures = "^12.0"
+pytest-rerunfailures = "^13.0"
 python-dotenv = "^1.0.0"
 
 
 [tool.poetry.group.py39-dev.dependencies]
-cairo-lang = {version = "0.12.2", python = ">=3.9, <3.10"}
+cairo-lang = {version = "0.13.0", python = ">=3.9, <3.10"}
 
 [tool.poe.tasks]
 test = [

diff --git a/starknet_py/abi/shape.py b/starknet_py/abi/shape.py
@@ -1,3 +1,5 @@
+# TODO (#1260): update pylint to 3.1.0 and remove pylint disable
+# pylint: disable=too-many-ancestors
 import sys
 from typing import List, Literal, Union
 

diff --git a/starknet_py/contract.py b/starknet_py/contract.py
@@ -853,6 +853,7 @@ async def declare_v2(
         max_fee: Optional[int] = None,
         auto_estimate: bool = False,
     ) -> DeclareResult:
+        # pylint: disable=too-many-arguments
         """
         Declares a contract.
 
@@ -893,6 +894,7 @@ async def declare_v3(
         l1_resource_bounds: Optional[ResourceBounds] = None,
         auto_estimate: bool = False,
     ) -> DeclareResult:
+        # pylint: disable=too-many-arguments
         """
         Declares a contract.
 

diff --git a/starknet_py/contract_test.py b/starknet_py/contract_test.py
@@ -7,7 +7,7 @@
 def test_compute_hash(balance_contract):
     assert (
         Contract.compute_contract_hash(balance_contract)
-        == 0x35074A58B8897CA3A38ACDD7636CA5FC530BBDA9F4FF896AB4205C6E846FF01
+        == 0x12177EA61E5791CC068D7EE979B74F60A7205A23404C07440F4892B826147C0
     )
 
 

diff --git a/starknet_py/hash/class_hash_test.py b/starknet_py/hash/class_hash_test.py
@@ -12,12 +12,12 @@
 
 @pytest.mark.parametrize(
     "contract_source, expected_class_hash", [
-        ("balance_compiled.json", 0x35074a58b8897ca3a38acdd7636ca5fc530bbda9f4ff896ab4205c6e846ff01),
-        ("map_compiled.json", 0x27e20b6e9c825b8a2de1a6fae317c0c05b0a3f1bc158c68885bd0fdf74e7d8e),
-        ("erc20_compiled.json", 0x7abcb4a526399039d84f20956d3dd25ec21ed56ac7a58841fc6d677f76f0f5e),
-        ("oz_proxy_compiled.json", 0x395e64cc7304606742f955ee576c79ae1b67d93d73bfc9ffe21c1088a86de34),
-        ("argent_proxy_compiled.json", 0x244c972f9ebd85f8390f1a4e56d5a10444933e75ad4fb4a1fc88f16c7fed148),
-        ("universal_deployer_compiled.json", 0x3f9c23fab233e00720eb3acc797d8f0d2e08907eac198e74ccd2631cc982265),
+        ("balance_compiled.json", 0x12177ea61e5791cc068d7ee979b74f60a7205a23404c07440f4892b826147c0),
+        ("map_compiled.json", 0x45dc8f1a90d242f9ebdd07c42301eb16845fbad294f7f9118cce544c16d64b4),
+        ("erc20_compiled.json", 0x528d1ce44f53e888c2259738018e2e77bea9cb97c8b7fc7edab67aa4a880181),
+        ("oz_proxy_compiled.json", 0x3e1526155defb7e26a017e9020e1043cce3c5a9144a9ce497c95648ababbdf1),
+        ("argent_proxy_compiled.json", 0x191295ed4e4bbc63209aaf4d025979f8180fe998c761f616ccd29b5acc8ae1f),
+        ("universal_deployer_compiled.json", 0x1fda6c88607d4edd7881671959cf73fb2172c952910a60f3d01ef0cd63a635),
         ("precompiled/oz_proxy_address_0.8.1_compiled.json", 0x413c36c287cb410d42f9e531563f68ac60a2913b5053608d640fb9b643acfe6),
     ]
 )

diff --git a/starknet_py/net/account/account.py b/starknet_py/net/account/account.py
@@ -495,6 +495,7 @@ async def sign_deploy_account_v1_transaction(
         max_fee: Optional[int] = None,
         auto_estimate: bool = False,
     ) -> DeployAccountV1:
+        # pylint: disable=too-many-arguments
         deploy_account_tx = DeployAccountV1(
             class_hash=class_hash,
             contract_address_salt=contract_address_salt,
@@ -522,6 +523,7 @@ async def sign_deploy_account_v3_transaction(
         l1_resource_bounds: Optional[ResourceBounds] = None,
         auto_estimate: bool = False,
     ) -> DeployAccountV3:
+        # pylint: disable=too-many-arguments
         deploy_account_tx = DeployAccountV3(
             class_hash=class_hash,
             contract_address_salt=contract_address_salt,
@@ -596,6 +598,8 @@ async def deploy_account_v1(
         max_fee: Optional[int] = None,
         auto_estimate: bool = False,
     ) -> AccountDeploymentResult:
+        # pylint: disable=too-many-arguments, too-many-locals
+
         """
         Deploys an account contract with provided class_hash on Starknet and returns
         an AccountDeploymentResult that allows waiting for transaction acceptance.
@@ -669,6 +673,8 @@ async def deploy_account_v3(
         l1_resource_bounds: Optional[ResourceBounds] = None,
         auto_estimate: bool = False,
     ) -> AccountDeploymentResult:
+        # pylint: disable=too-many-arguments
+
         """
         Deploys an account contract with provided class_hash on Starknet and returns
         an AccountDeploymentResult that allows waiting for transaction acceptance.

diff --git a/starknet_py/net/account/base_account.py b/starknet_py/net/account/base_account.py
@@ -214,6 +214,7 @@ async def sign_deploy_account_v1_transaction(
         max_fee: Optional[int] = None,
         auto_estimate: bool = False,
     ) -> DeployAccountV1:
+        # pylint: disable=too-many-arguments
         """
         Create and sign deploy account transaction version 1.
 
@@ -239,6 +240,7 @@ async def sign_deploy_account_v3_transaction(
         l1_resource_bounds: Optional[ResourceBounds] = None,
         auto_estimate: bool = False,
     ) -> DeployAccountV3:
+        # pylint: disable=too-many-arguments
         """
         Create and sign deploy account transaction version 3.
 

diff --git a/starknet_py/serialization/data_serializers/option_serializer.py b/starknet_py/serialization/data_serializers/option_serializer.py
@@ -1,11 +1,13 @@
 from dataclasses import dataclass
 from typing import Any, Generator, Optional
 
-from starknet_py.serialization import CairoDataSerializer
 from starknet_py.serialization._context import (
     DeserializationContext,
     SerializationContext,
 )
+from starknet_py.serialization.data_serializers.cairo_data_serializer import (
+    CairoDataSerializer,
+)
 
 
 @dataclass

diff --git a/starknet_py/serialization/data_serializers/output_serializer.py b/starknet_py/serialization/data_serializers/output_serializer.py
@@ -1,11 +1,13 @@
 from dataclasses import dataclass, field
 from typing import Dict, Generator, List, Tuple
 
-from starknet_py.serialization import CairoDataSerializer
 from starknet_py.serialization._context import (
     DeserializationContext,
     SerializationContext,
 )
+from starknet_py.serialization.data_serializers.cairo_data_serializer import (
+    CairoDataSerializer,
+)
 
 
 @dataclass

diff --git a/starknet_py/serialization/data_serializers/uint_serializer.py b/starknet_py/serialization/data_serializers/uint_serializer.py
@@ -2,12 +2,14 @@
 from typing import Generator, TypedDict, Union
 
 from starknet_py.cairo.felt import uint256_range_check
-from starknet_py.serialization import CairoDataSerializer
 from starknet_py.serialization._context import (
     Context,
     DeserializationContext,
     SerializationContext,
 )
+from starknet_py.serialization.data_serializers.cairo_data_serializer import (
+    CairoDataSerializer,
+)
 
 
 class Uint256Dict(TypedDict):

diff --git a/starknet_py/serialization/data_serializers/unit_serializer.py b/starknet_py/serialization/data_serializers/unit_serializer.py
@@ -1,11 +1,13 @@
 from dataclasses import dataclass
 from typing import Any, Generator, Optional
 
-from starknet_py.serialization import CairoDataSerializer
 from starknet_py.serialization._context import (
     DeserializationContext,
     SerializationContext,
 )
+from starknet_py.serialization.data_serializers.cairo_data_serializer import (
+    CairoDataSerializer,
+)
 
 
 @dataclass