Setup vscode tests #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Draggu
requested review from
mkaput,
Arcticae and
piotmag769
and removed request for
a team
Draggu
force-pushed
the
spr/main/633829f2
branch
2 times, most recently
from
7346ea3 to
c556f84
Compare
mkaput
requested changes
Dec 6, 2024
Draggu
force-pushed
the
spr/main/633829f2
branch
from
c556f84 to
e50bbcb
Compare
Merged
Draggu
force-pushed
the
spr/main/633829f2
branch
from
e50bbcb to
bae6bc2
Compare
piotmag769
approved these changes
Dec 10, 2024
Closed
mkaput
requested changes
Dec 11, 2024
There was a problem hiding this comment.
Copilot reviewed 5 out of 7 changed files in this pull request and generated no suggestions.
Files not reviewed (2)
- package.json: Language not supported
- ui-test/settings.json: Language not supported
Comments skipped due to low confidence (2)
.github/workflows/ci.yaml:39
- [nitpick] The job name 'test ui' is ambiguous and inconsistent. It should be renamed to 'ui-tests' for clarity and consistency.
name: test ui
eslint.config.mjs:9
- [nitpick] The ignore pattern ".test-extensions" is ambiguous. Consider renaming it to something more descriptive, such as "test-extensions/*".
ignores: ["dist/*", "out/*", ".test-extensions"]
bae6bc2 to
f145f0a
Compare
This was referenced Dec 12, 2024
Closed
Closed
Closed
mkaput
approved these changes
Dec 12, 2024
commit-id:633829f2
Draggu
force-pushed
the
spr/main/633829f2
branch
from
f145f0a to
0fcc3b4
Compare
This was referenced Dec 12, 2024
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack:
test-support/cairo-snippets.gen.ts#32