Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scarb from correct source test #58

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Scarb from correct source test #58

merged 1 commit into from
Jan 10, 2025

Conversation

Draggu
Copy link
Contributor

@Draggu Draggu commented Jan 8, 2025 •
edited
Loading

No description provided.

@Draggu Draggu requested a review from a team as a code owner January 8, 2025 10:23
@Draggu Draggu requested review from Arcticae and integraledelebesgue and removed request for a team January 8, 2025 10:23
This was referenced Jan 8, 2025
Merged
Merged
@Draggu
Copy link
Contributor Author

Draggu commented Jan 8, 2025

This is #34 but had to reopen because of spr

@mkaput mkaput requested review from mkaput and removed request for integraledelebesgue January 9, 2025 06:25
mkaput
mkaput requested changes Jan 9, 2025
View reviewed changes
test/getStatusBarItem.ts Outdated Show resolved Hide resolved
test/lsVersion.ts Outdated Show resolved Hide resolved
test/lsVersion.ts Outdated Show resolved Hide resolved
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
@Draggu Draggu force-pushed the spr/main/28a8da67 branch from f01f232 to 8f47c72 Compare January 9, 2025 11:18
@Draggu Draggu force-pushed the spr/main/64f5ed40 branch from 161eafa to 566f2f4 Compare January 9, 2025 11:18
Base automatically changed from spr/main/64f5ed40 to main January 9, 2025 12:33
@Draggu Draggu force-pushed the spr/main/28a8da67 branch 3 times, most recently from 2c33e8c to 56f5e76 Compare January 9, 2025 14:07
mkaput
mkaput requested changes Jan 10, 2025
View reviewed changes
ui-test/scarb/toolchain_info.ts Outdated Show resolved Hide resolved
@Draggu Draggu force-pushed the spr/main/28a8da67 branch from 56f5e76 to 3971aa6 Compare January 10, 2025 09:33
@Draggu Draggu requested a review from mkaput January 10, 2025 09:33
@Draggu Draggu added this pull request to the merge queue Jan 10, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 10, 2025
@Draggu Draggu added this pull request to the merge queue Jan 10, 2025
Merged via the queue into main with commit e0d98cd Jan 10, 2025
19 checks passed
@Draggu Draggu deleted the spr/main/28a8da67 branch January 10, 2025 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arcticae Arcticae Arcticae approved these changes

@mkaput mkaput mkaput approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Draggu @mkaput @Arcticae