Unify error handling #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamw
reviewed
Oct 30, 2023
README.md
Outdated
| @@ -628,10 +628,76 @@ exception being thrown there. | |||
| Won't this design cause upstream channels / sources to operate despite the consumer being gone (because of the | |||
| exception)? | |||
|
|
|||
| No: the exception should cause the containing scope to finish (or a supervised fork to fail), cancelling any forks | |||
| that are operating in the background. Any unused channels can then be garbage-collected. | |||
| It depends on two factors: | |||
There was a problem hiding this comment.
I think I would mention beforehand that there are two possible designs, of which we picked one, as otherwise this might make the impression that error handling in Ox is dependent on the factors below (which it isn't)
There was a problem hiding this comment.
In fact ... such a discussion would be better placed in and ADR. Maybe this should be moved there? ADRs can be as simple as a text file, e.g. here: https://github.com/softwaremill/tapir/tree/master/doc/adr
The docs can then simply state the current state of affairs, keeping the design discussions separate
There was a problem hiding this comment.
Good point, moved the discussion to an ADR.
geminicaprograms
approved these changes
Oct 30, 2023
adamw
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mapParScopedoesn't rethrow anymorepipeTodoesn't rethrow when receiving from upstream failsmapParUnordered