Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add zio-http multipart body support #3690

Merged

Conversation

seakayone
Copy link
Contributor

@seakayone seakayone commented Apr 16, 2024

Resolves #2518

Currently tests fail because the incoming ServerRequest contains the multiple parts, but when calling zio.http.Request.body.[asMultipartFormStream|asMultiPartForm] they only ever return the single, first part.

Seems to be a bug in zio-http: zio/zio-http#2411

Bug was fixed and released. I have let the build run in my own actions and it succeded: https://github.com/seakayone/tapir/actions/runs/9943391610

@seakayone seakayone changed the title feat: Add zio multipart body support feat: Add zio-http multipart body support Apr 16, 2024
@seakayone seakayone force-pushed the feat/add-zio-multipart-body-support branch 3 times, most recently from 2090a02 to 8623fa2 Compare April 16, 2024 14:11
@godspeedelbow
Copy link

@seakayone now that #3690 is merged, can you put up this PR for review?

@seakayone
Copy link
Contributor Author

I am planning to finalize this PR in the next couple of days hopefully.

@seakayone seakayone force-pushed the feat/add-zio-multipart-body-support branch from 64b870f to 5488c26 Compare July 15, 2024 13:55
@seakayone seakayone marked this pull request as ready for review July 16, 2024 09:23
@seakayone seakayone marked this pull request as draft July 23, 2024 12:14
@adamw
Copy link
Member

adamw commented Jul 23, 2024

There's some problems updating ZIO, I think we'll need to first tackle #3876, and then get back to this PR. Sorry for the problems :)

@adamw
Copy link
Member

adamw commented Jul 24, 2024

Found the problem in zio-http: zio/zio-http#2977

@alexander-klimov
Copy link
Contributor

alexander-klimov commented Aug 9, 2024

Hello.
Any news on this one and #3876 ?
Really eager to start using multipart requests -_-

@seakayone zio/zio-http#2977 was closed

@resilica
Copy link

@adamw Is there anything blocking for this to be merged? The underlying bugs are resolved and we are waiting for this fix. Thanks!

@geeeezmo
Copy link

@adamw Is there anything blocking for this to be merged? The underlying bugs are resolved and we are waiting for this fix. Thanks!

I'm guessing it's the same reason

@adamw
Copy link
Member

adamw commented Sep 2, 2024

@resilica @geeeezmo yes, unfortunately RC9 had a bug which prevented the update, there's another one now in RC10.

@alexander-klimov
Copy link
Contributor

alexander-klimov commented Sep 11, 2024

@seakayone can this PR be made public so it can be reviewed?
Because #4034 that updates zio-http to 3.0.0 has been merged.

@adamw adamw marked this pull request as ready for review September 17, 2024 09:26
@adamw adamw merged commit 9a3b92a into softwaremill:master Sep 17, 2024
26 checks passed
@adamw
Copy link
Member

adamw commented Sep 17, 2024

Thanks for the work, needed a little push to get over the finish line, tests are now green :)

@alexander-klimov
Copy link
Contributor

Thank you, Adam, for all the work you do.
Can't wait for the next release 🙃

@seakayone seakayone deleted the feat/add-zio-multipart-body-support branch September 18, 2024 10:05
@seakayone
Copy link
Contributor Author

@adamw Thanks for finalizing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request hanging on multipartBody file uploads with zio-http
6 participants