codegen: Support enums in paths #3889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hughsimpson
commented
Jul 1, 2024
| @@ -169,10 +172,6 @@ object BasicGenerator { | |||
| | case Some(values) => DecodeResult.sequence(values.split(',').toSeq.map(e => support.rawDecode(List(e)))).map(r => Some(CommaSeparatedValues(r.toList))) | |||
| | }(_.map(_.values.map(support.encode).mkString(","))) | |||
| |} | |||
| |implicit def makeExplodedQuerySeqCodecFromSupport[T](implicit support: QueryParamSupport[T]): sttp.tapir.Codec[List[String], ExplodedValues[T], sttp.tapir.CodecFormat.TextPlain] = { | |||
There was a problem hiding this comment.
Since we now provide a Codec[String, T, sttp.tapir.CodecFormat.TextPlain], from which we can derive a Codec[List[String], List[T], sttp.tapir.CodecFormat.TextPlain], the final implicit derivation is provided by makeExplodedQuerySeqCodecFromListSeq and this is now redundant (it also causes explicit resolution conflicts in scala 3 if left in, although scala 2 seems happy enough with the ambiguity for some reason).
hughsimpson
commented
Jul 1, 2024
| .leftMap(err => err: Error) | ||
| .flatMap(_.as[OpenapiDocument]) shouldBe Right( | ||
| TestHelpers.enumQueryParamDocs | ||
| ) |
There was a problem hiding this comment.
This test was previously missing
|
@hughsimpson I'd like to release |
|
@kciesielski I've got nothing else I need, would love a 1.10.11! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support enums in path params. Most of the diff here is just renaming variables and types to reflect that they no longer pertain only to query params, but also to path params; nearly all of the implementation is supported just by reusing those existing mechanisms