Fix tests

test/hermes_test/commands/deposit/test_invenio.py

@@ -5,6 +5,8 @@
 # SPDX-FileContributor: Michael Meinel
 # SPDX-FileContributor: David Pape
 
+from unittest import mock
+
 import click
 import pytest
 
@@ -14,33 +16,47 @@
 
 @pytest.fixture
 def resolver():
-    return invenio.InvenioResolver()
+    with mock.patch("hermes.config.get") as mocked_deposit_config:
+        mocked_deposit_config.return_value = {
+            "invenio": {
+                "site_url": "https://invenio.example.com",
+            }
+        }
+        r = invenio.InvenioResolver()
+    return r
 
 
 @pytest.fixture
 def depositor():
     click_ctx = click.Context(click.Command("deposit"))
     click_ctx.params.update({"auth_token": ""})
-    return invenio.InvenioDepositPlugin(click_ctx, None)
+    with mock.patch("hermes.config.get") as mocked_deposit_config:
+        mocked_deposit_config.return_value = {
+            "invenio": {
+                "site_url": "https://invenio.example.com",
+            }
+        }
+        d = invenio.InvenioDepositPlugin(click_ctx, None)
+    return d
 
 
 def test_resolve_doi(requests_mock, resolver):
     requests_mock.get('https://doi.org/123.45/foo.bar-6789',
                       status_code=302,
-                      headers={'Location': 'https://foo.bar/record/6789'})
-    requests_mock.get('https://foo.bar/record/6789')
+                      headers={'Location': 'https://invenio.example.com/record/6789'})
+    requests_mock.get('https://invenio.example.com/record/6789')
 
-    assert resolver.resolve_doi('https://foo.bar', '123.45/foo.bar-6789') == '6789'
+    assert resolver.resolve_doi('123.45/foo.bar-6789') == '6789'
 
 
 def test_resolve_doi_wrong_host(requests_mock, resolver):
     requests_mock.get('https://doi.org/123.45/foo.bar-6789',
                       status_code=302,
-                      headers={'Location': 'https://foo.baz/record/6789'})
-    requests_mock.get('https://foo.baz/record/6789')
+                      headers={'Location': 'https://not.invenio.example.com/record/6789'})
+    requests_mock.get('https://not.invenio.example.com/record/6789')
 
     with pytest.raises(ValueError):
-        resolver.resolve_doi('https://foo.bar', '123.45/foo.bar-6789')
+        resolver.resolve_doi('123.45/foo.bar-6789')
 
 
 def test_resolve_doi_unknown(requests_mock, resolver):
@@ -52,101 +68,101 @@ def test_resolve_doi_unknown(requests_mock, resolver):
     requests_mock.get('https://datacite.org/404.html', status_code=200)
 
     with pytest.raises(ValueError):
-        resolver.resolve_doi('https://foo.bar', '123.45/foo.bar-6789')
+        resolver.resolve_doi('123.45/foo.bar-6789')
 
 
 def test_resolve_record_id(requests_mock, resolver):
-    requests_mock.get('https://foo.bar/api/records/6789',
-                      text='{"links":{"latest":"https://foo.bar/api/records/12345"}}')
-    requests_mock.get('https://foo.bar/api/records/12345', text='{"id":"12345","metadata":{"mock":42}}')
+    requests_mock.get('https://invenio.example.com/api/records/6789',
+                      text='{"links":{"latest":"https://invenio.example.com/api/records/12345"}}')
+    requests_mock.get('https://invenio.example.com/api/records/12345', text='{"id":"12345","metadata":{"mock":42}}')
 
-    assert resolver.resolve_record_id('https://foo.bar', '6789') == ('12345', {"mock": 42})
+    assert resolver.resolve_record_id('6789') == ('12345', {"mock": 42})
 
 
 def test_resolve_record_id_unknown(requests_mock, resolver):
-    requests_mock.get('https://foo.bar/api/records/6789', status_code=404, text="Not found")
+    requests_mock.get('https://invenio.example.com/api/records/6789', status_code=404, text="Not found")
 
     with pytest.raises(ValueError):
-        resolver.resolve_record_id('https://foo.bar', '6789')
+        resolver.resolve_record_id('6789')
 
 
 def test_resolve_record_id_latest_unknown(requests_mock, resolver):
-    requests_mock.get('https://foo.bar/api/records/6789',
-                      text='{"links":{"latest":"https://foo.bar/api/records/12345"}}')
-    requests_mock.get('https://foo.bar/api/records/12345', status_code=404)
+    requests_mock.get('https://invenio.example.com/api/records/6789',
+                      text='{"links":{"latest":"https://invenio.example.com/api/records/12345"}}')
+    requests_mock.get('https://invenio.example.com/api/records/12345', status_code=404)
 
     with pytest.raises(ValueError):
-        resolver.resolve_record_id('https://foo.bar', '6789')
+        resolver.resolve_record_id('6789')
 
 
 def test_get_access_modalities_closed(depositor):
-    depositor.config = {'access_right': 'closed'}
+    depositor.config.update({'access_right': 'closed'})
     access_right, _, _ = depositor._get_access_modalities(None)
     assert access_right == "closed"
 
 
 def test_get_access_modalities_embargoed_no_date_no_license(depositor):
-    depositor.config = {'access_right': 'embargoed'}
+    depositor.config.update({'access_right': 'embargoed'})
     with pytest.raises(MisconfigurationError):
         depositor._get_access_modalities(None)
 
 
 def test_get_access_modalities_embargoed_no_date_with_license(depositor):
-    depositor.config = {'access_right': 'embargoed'}
+    depositor.config.update({'access_right': 'embargoed'})
     with pytest.raises(MisconfigurationError):
         depositor._get_access_modalities("Apache-2.0")
 
 
 def test_get_access_modalities_embargoed_with_date_with_license(depositor):
-    depositor.config = {
+    depositor.config.update({
         'access_right': 'embargoed',
         'embargo_date': '2050-05-01',
-    }
+    })
     access_right, embargo_date, _ = depositor._get_access_modalities("Apache-2.0")
     assert access_right == "embargoed"
     assert embargo_date == "2050-05-01"
 
 
 def test_get_access_modalities_embargoed_with_broken_date_with_license(depositor):
-    depositor.config = {
+    depositor.config.update({
         'access_right': 'embargoed',
         'embargo_date': 'not-a-date',
-    }
+    })
     with pytest.raises(MisconfigurationError):
         depositor._get_access_modalities("Apache-2.0")
 
 
 def test_get_access_modalities_restricted_no_conditions(depositor):
-    depositor.config = {'access_right': 'restricted'}
+    depositor.config.update({'access_right': 'restricted'})
     with pytest.raises(MisconfigurationError):
         depositor._get_access_modalities(None)
 
 
 def test_get_access_modalities_restricted_with_conditions(depositor):
-    depositor.config = {
+    depositor.config.update({
         'access_right': 'restricted',
         'access_conditions': 'You must be cool',
-    }
+    })
     access_right, _, access_conditions = depositor._get_access_modalities(None)
     assert access_right == "restricted"
     assert access_conditions == "You must be cool"
 
 
 def test_get_access_modalities_open_no_license(depositor):
-    depositor.config = {'access_right': 'open'}
+    depositor.config.update({'access_right': 'open'})
     with pytest.raises(MisconfigurationError):
         depositor._get_access_modalities(None)
 
 
 def test_get_access_modalities_open_with_license(depositor):
-    depositor.config = {'access_right': 'open'}
+    depositor.config.update({'access_right': 'open'})
     access_right, _, _ = depositor._get_access_modalities("Apache-2.0")
     assert access_right == "open"
 
 
 def test_get_access_modalities_broken_access_right(depositor):
-    depositor.config = {
+    depositor.config.update({
         'access_right': 'unknown',  # does not exist
-    }
+    })
     with pytest.raises(MisconfigurationError):
         depositor._get_access_modalities(None)