Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix logging-related crash in hermes clean #226

Merged
merged 2 commits into from
Nov 1, 2023
Merged

Fix logging-related crash in hermes clean #226

merged 2 commits into from
Nov 1, 2023

Commits on Nov 1, 2023

  1. Use terminal-only logger for hermes clean

    @zyzzyxdonta
    zyzzyxdonta committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    e9ac246 View commit details
    Browse the repository at this point in the history

  2. Shutdown logging before cleaning files 

    This ensures that any and all opened logging files in the .hermes
directory are closed, allowing us to safely remove that directory.
    @zyzzyxdonta
    zyzzyxdonta committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    895bdef View commit details
    Browse the repository at this point in the history