First step towards the new data model #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ermes_push_token-not-documented Add HERMES_PUSH_TOKEN
Note: Still not working as we get SPDX URLs but the URLs on Zenodo / InvenioRDM are opensource.org URLs
…ourney. Thanks to @zyzzyxdonta for the hint.
This is still based on C&P... should we extract the "common base" that is still valid and only migrate the relevant parts? Also: I stupidly changed all string occurrences... to also distinguish configurations and avoid accidential mis-use.
This ensures that any and all opened logging files in the .hermes directory are closed, allowing us to safely remove that directory.
…s-clean Fix logging-related crash in `hermes clean`
Fix InvenioRDM license checks in new InvenioRDM plugin
This might have been parametrized or implemented differently to distinguish between Invenio and InvenioRDM. However, this way works without further coding headache...
Further fixes to InvenioRDM to work properly with the tutorial (... and at all)
This is still based on C&P... should we extract the "common base" that is still valid and only migrate the relevant parts? Also: I stupidly changed all string occurrences... to also distinguish configurations and avoid accidential mis-use.
This ensures that any and all opened logging files in the .hermes directory are closed, allowing us to safely remove that directory.
This might have been parametrized or implemented differently to distinguish between Invenio and InvenioRDM. However, this way works without further coding headache...
…oring-of-data-model
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Context is replaced by the linked_data module providing data classes... many copy and paste but also lots of deletions so far.
The data is now no longer "JSON-LD" all the time but we use a little trick to annotate metadata to the attributes:
Values are wrapped in an dict that has the @value tag with the actual value and a @metadata tag with the metadata. In addition, there might be an @alternatives tag that carries a list of other possible values.
Related to #230, implementing updated ADRs as outlined in #232