Fixes from the first release #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Problems should be fixed, however at least the regressions from the issue should be covered by tests - ideally, even more! @SKernchen @poikilotherm @zyzzyxdonta feel free to contribute further tests... ;) (And also have a look at the |
There is no consistent use yet, some exceptions are re-raised, some are logged to an internal error register of the command...
|
Parsed incorrectly by me, this has been ticked off in the issue because it was moved to a separate one. |
SKernchen
approved these changes
Aug 9, 2024
zyzzyxdonta
previously requested changes
Aug 9, 2024
led02
dismissed
zyzzyxdonta’s stale review
Changes are applied, I want to merge now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The points are collected in #244.