Code

Contact organizers form#1390

Code

Merged

leider merged 48 commits intosoftwerkskammer:mastersoftwerkskammer/Agora:masterfrom UrsMetz:contact-organizers-formUrsMetz/Agora:contact-organizers-formCopy head branch name to clipboardJul 8, 2019

+532-55

Commits

Commits on Jul 2, 2019

• First step towards contact organizers feature

  UrsMetz

  committed
  b6c94c6

• load organizers for a group

  

  signed

  authored and

  UrsMetz

  committed
  855942a

• extend group to store the opt in flag for contact the organizers

  

  signed

  authored and

  UrsMetz

  committed
  da42c7c

• add changes from review

  

  signed

  authored and

  UrsMetz

  committed
  e12db50

• add checkbox for contactTheOrganizers feature

  

  signed

  authored and

  UrsMetz

  committed
  3f6ad7a

• Rename for clarity

  UrsMetz

  committed
  81b6c95

• Mail to organizers is only sent when the feature is enabled in the group

  UrsMetz

  committed
  51bd076

• i18n message when group has not organizers

  UrsMetz

  committed
  f2c625d

• better method name

  

  signed

  authored and

  UrsMetz

  committed
  984bc92

• reduce duplication in tests

  

  signed

  authored and

  UrsMetz

  committed
  5d6c6ac

• reduce duplication in tests part two

  

  signed

  authored and

  UrsMetz

  committed
  c07a7ea

• better names

  

  signed

  authored and

  UrsMetz

  committed
  07a9c01

• for now only show contact the organizers to members of the group

  

  signed

  authored and

  UrsMetz

  committed
  0aed375

• only show the contact the organizers link if the organizers enabled it

  

  signed

  authored and

  UrsMetz

  committed
  90b5238

• Fix: getGroups returns an array

  UrsMetz

  committed
  a9eac54

• Handle case when group for id not found

  UrsMetz

  committed
  3c25fc5

• Add hint to offer contact information

  Show description for 86d16ee
  UrsMetz

  committed
  86d16ee

• Fix lint error: don't use 'use strict'

  UrsMetz

  committed
  a43c7ea

• More accurate error message

  UrsMetz

  committed
  f2c67d4

• "contact the organizers" now in i18n

  UrsMetz

  committed
  0b3c6c4

• Reorder and rename group contact options

  UrsMetz

  committed
  8821c84

• Also registered users that are not members can contact the organizers

  UrsMetz

  committed
  fdccae1

• Remove double empty line

  UrsMetz

  committed
  86388ed

• Add function name for better debuggability

  UrsMetz

  committed
  c38ef48

• Make link to organizer contact form a button and change its label

  UrsMetz

  committed
  6e49cb2

• Make names and content consistent with current implementation

  UrsMetz

  committed
  5c401e9

• Remove unnecessary hint about contact information

  Show description for 01c1f90
  UrsMetz

  committed
  01c1f90

• Rename getter that indicates whether "contact the organizers" feature is enabled

  UrsMetz

  committed
  a5b397b

• Add name to function for better debuggability

  UrsMetz

  committed
  3520bf6

• Use more idiomatic JavaScript to handle undefined property

  UrsMetz

  committed
  4021fed

• Prepend subject with prefix so that source of mail is clear

  UrsMetz

  committed
  d783247

• Move display logic for button into accessrights

  UrsMetz

  committed
  3ec18b6

• Change text for disabled feature

  UrsMetz

  committed
  3ae3a22

• Rename form field contactPersonsGroupName to groupNameForContact

  UrsMetz

  committed
  c864e6d

• Move logic for flag conversion into constructor

  UrsMetz

  committed
  dd8ec33

• Make error message more generic and only log details

  UrsMetz

  committed
  184ef63

• Add mail evelope icon for mail button

  UrsMetz

  committed
  5f00f55

• Shorten text for configuration option in group form

  UrsMetz

  committed
  7504642

• Reduce nesting of describes in test

  UrsMetz

  committed
  21880aa

• Move logic to find members that are organizes into Group

  UrsMetz

  committed
  71965ea

• Inline group creation in test cases

  UrsMetz

  committed
  3726eda

• clean up describe block in test

  UrsMetz

  committed
  b3a5ecb

• Add test for several organizes in group

  UrsMetz

  committed
  8d1490d

• Correct typo and align variable names

  UrsMetz

  committed
  94eb0e4

• Inline some test data creation, compact describes and include before eachs in it blocks

  UrsMetz

  committed
  79fb2eb

• Fix typo

  UrsMetz

  committed
  5677536

Commits on Jul 7, 2019

• Make test data a const rather than a function

  UrsMetz

  committed
  dc80704

• Only show button to contact organizers when there any

  UrsMetz

  committed
  5d21134