Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Launcher based on JSON Configuration and CIMpy #259

Closed
wants to merge 94 commits into from
Closed

Conversation

martinmoraga
Copy link
Contributor

This PR implements:

  • CIM2DPsim: new cim Reader based on cimpy
  • DPsim2CIM: new converter dpsim to cimpy based on cimpy
  • DPsimLauncher

Based on #243 and on this PR of cimpy

martinmoraga and others added 30 commits October 19, 2023 11:03
Signed-off-by: Martin Moraga <[email protected]>
Signed-off-by: Martin Moraga <[email protected]>
Signed-off-by: Martin Moraga <[email protected]>
Signed-off-by: Martin Moraga <[email protected]>
Signed-off-by: Martin Moraga <[email protected]>
Signed-off-by: Martin Moraga <[email protected]>
Signed-off-by: Martin Moraga <[email protected]>
Signed-off-by: Martin Moraga <[email protected]>
Signed-off-by: Martin Moraga <[email protected]>
Hydro/Steam Turbine and Governor documentation hast been added. The pictures will be added after test

Signed-off-by: Glebs Ogorodniks <[email protected]>
Signed-off-by: Martin Moraga <[email protected]>
Signed-off-by: Martin Moraga <[email protected]>
Signed-off-by: Martin Moraga <[email protected]>
Signed-off-by: Martin Moraga <[email protected]>
Signed-off-by: Martin Moraga <[email protected]>
martinmoraga and others added 16 commits October 20, 2023 08:38
Signed-off-by: Martin Moraga <[email protected]>
Signed-off-by: Martin Moraga <[email protected]>
Signed-off-by: Glebs Ogorodniks <[email protected]>
Signed-off-by: Canfirat98 <[email protected]>
Signed-off-by: Canfirat98 <[email protected]>
Signed-off-by: Canfirat98 <[email protected]>
Signed-off-by: Canfirat98 <[email protected]>
Signed-off-by: Canfirat98 <[email protected]>
@martinmoraga martinmoraga self-assigned this Oct 26, 2023
@martinmoraga martinmoraga added the enhancement New feature or request label Oct 26, 2023
Signed-off-by: Martin Moraga <[email protected]>
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot E 6 Security Hotspots
Code Smell A 255 Code Smells

0.0% 0.0% Coverage
13.6% 13.6% Duplication

warning The version of Java (11.0.14.1) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@dinkelbachjan dinkelbachjan changed the title Ba can DPsim Launcher based on JSON Configuration and CIMpy Oct 26, 2023
@dinkelbachjan dinkelbachjan changed the title DPsim Launcher based on JSON Configuration and CIMpy Launcher based on JSON Configuration and CIMpy Oct 26, 2023
@stv0g
Copy link
Contributor

stv0g commented Oct 27, 2023

Cool @martinmoraga,

cant wait for this to land! Do want to wait until #243 is merged? Or can we rebase the launcher changes onto master and merge them separately?

@martinmoraga
Copy link
Contributor Author

Cool @martinmoraga,

cant wait for this to land! Do want to wait until #243 is merged? Or can we rebase the launcher changes onto master and merge them separately?

@stv0g
I think we should wait, since I don't know if everything will work well...

@stv0g
Copy link
Contributor

stv0g commented Feb 26, 2024

It also seems to me that this PR is based on some other (SG controllers)?

In order to merge this, we would need to isolate the changes (rebase to master) or merge the controllers first.

@stv0g stv0g closed this Nov 13, 2024
@stv0g stv0g deleted the ba-can branch November 13, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

7 participants