Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sonar scanner errors due to Java deprecated version #265

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

leonardocarreras
Copy link
Collaborator

@leonardocarreras leonardocarreras commented Nov 12, 2023

Due to end of support of the Java 11 (LTS) in Sonar, this PR updates the version of Sonar Scanner to 5.0.1.3006. Additionally, the warnings because of Node.js (version 16 to be unsupported in the near future) are corrected. Actions cache is also updated to v4. The action for setup-java was removed (we use now the JRE included in sonar-scanner).

This closes #251

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.14.1) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@leonardocarreras leonardocarreras marked this pull request as ready for review November 29, 2023 14:19
@dinkelbachjan
Copy link
Contributor

There is a also new way (not sure if better) to make this type of solutions in this style here

name: Build
on:
  push:
    branches:
      - main
  pull_request:
    types: [opened, synchronize, reopened]
jobs:
  build:
    name: Build
    runs-on: ubuntu-latest
    env:
      BUILD_WRAPPER_OUT_DIR: build_wrapper_output_directory # Directory where build-wrapper output will be placed
    steps:
      - uses: actions/checkout@v3
        with:
          fetch-depth: 0 # Shallow clones should be disabled for a better relevancy of analysis
      - name: Install sonar-scanner and build-wrapper
        uses: SonarSource/sonarcloud-github-c-cpp@v1
      - name: Run build-wrapper
        run: |
          mkdir build
          cmake -S . -B build
          build-wrapper-linux-x86-64 --out-dir ${{ env.BUILD_WRAPPER_OUT_DIR }} cmake --build build/ --config Release
      - name: Run sonar-scanner
        env:
          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
          SONAR_TOKEN: ${{ secrets.SONARCLOUD_TOKEN }} # Put the name of your token here
        run: |
          sonar-scanner --define sonar.cfamily.build-wrapper-output="${{ env.BUILD_WRAPPER_OUT_DIR }}"

As an future option, we can move to that and use the SonarSource/sonarcloud-github-c-cpp@v1 action. The clear advantage is that this solution does not install separately JDK, then we get rid of the maintenance of the toolchain

@leonardocarreras leonardocarreras changed the title Bumping JDK v11->17 and setup-java v1->v3 Fix sonar scanner errors due to Java deprecated version Jan 25, 2024
Due to end of support of the Java 11 LTS in Sonar, this is needed to continue using the software.

The JRE included in the sonar-scanner is used to keep the version of Java current, and that is the reason for a newer version.

Node.js version was updated to suppress the warning for a future end of support.

Signed-off-by: Leonardo Carreras <[email protected]>
@leonardocarreras
Copy link
Collaborator Author

All commits were squashed to avoid intermediate non-working solutions going to master branch

Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@dinkelbachjan dinkelbachjan merged commit 94770e9 into master Jan 25, 2024
21 checks passed
@stv0g stv0g deleted the fix-sonar-jdk branch February 28, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Java is too old in Sonar - need to update from 11 to 17+
2 participants