Trigger actions for PRs and pin the version of libcimpp

[gnakti]

• Since we work now mainly from forks, I extended the actions triggered on: push to be additionally triggered on: pull_request. Activity types set to types: [opened, synchronize, reopened]. For more details see here. An optimised version of this is to additionally prevent feature branches to trigger on push when they already have a PR: on: [push, pull_request]
• Pin the version of libcimpp to avoid failure of windows workflow caused by sogno-platform/libcimpp#29.

[leonardocarreras]

It looks like there is a non-related problem (the Windows runner changed) that maybe is also possible to solve in the PR or in a different one, by explicitly installing this library just after the checkout process... In theory, the solution could be something like this...

    - name: Install dependencies (LibXml2)
      uses: microsoft/vcpkg-action@v2
      with:
        vcpkgArgs: install libxml2

and later, adding it to the path for cmake

        cmake -DWITH_PYBIND=OFF -DCMAKE_TOOLCHAIN_FILE=$VCPKG_ROOT/scripts/buildsystems/vcpkg.cmake ..

[gnakti]

Thanks @leonardocarreras!
Better solve it in a new PR with a new branch.

[stv0g]

Maybe the failing pipeline is caused by sogno-platform/libcimpp#29 ?

If thats the case, we should really pin the version of libcimpp which is used to avoid such breakage in the future.

/cc @m-mirz

[m-mirz]

Maybe the failing pipeline is caused by sogno-platform/libcimpp#29 ?

If thats the case, we should really pin the version of libcimpp which is used to avoid such breakage in the future.

/cc @m-mirz

@stv0g yes, the version should be pinned. I thought this was already the case. In this libcimpp PR we dropped support for every parser except libxml. So windows does not work out of the box but with @leonardocarreras suggestion it might work. Let me know if you think this change causes too many issues. Basically, I would like to get rid of the arabica library.

[gnakti]

I edited the PR to pin the version of libcimpp. Let's do that first and then test the proposition of @leonardocarreras in a separate PR.

[leonardocarreras]

I edited the PR to pin the version of libcimpp. Let's do that first and then test the proposition of @leonardocarreras in a separate PR.

@gnakti I added a pinning to the library for cmake and for the containers, and also fixed the sonarcloud execution by skipping gracefully when the secrets are not visible due to the package being triggered in a fork...

[leonardocarreras]

It runs in Windows too, I think we can consider it ready for review again @m-mirz @stv0g
Long term we will need to think when/if to implement the breaking changes