do not propagate "use of closed conn" error if expected #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's unfortunately no way (AFAIK) of actively interrupting a net.Listener.Accept() call, so we have to deal with it erroring out when its net.Listener is closed. Unfortunately(2) there's also no better way of matching the low-level error than string checks, since it is not exported by the stdlib.
|
with never version of go you can do errors.Is |
|
hi @vtolstov
(nevermind; see below) |
|
Ah, I take it back: looks like it was indirectly exported in 1.16. I'll see if that works. |
yes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's unfortunately no way (AFAIK) of actively interrupting a
net.Listener.Accept()call, so we have to deal with it erroring out if/whenits net.Listener is closed (see #39).
Unfortunately(2) there's also no better way of matching the low-level
error than string checks, since it is not exported by the stdlib.