-
Notifications
You must be signed in to change notification settings - Fork 477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ListView to Flatlist #230
base: master
Are you sure you want to change the base?
Conversation
e928978
to
05dea1a
Compare
@sohobloo - any updates I should make for this? |
I had the same issue as well. Please merge this PR |
I am also getting same issue please merge this PR. @sohobloo |
Any update on this @sohobloo . |
@Rahulv2492 : also feel free to use the forked package as we keep it up to date: https://github.com/BuildU/react-native-modal-dropdown In your |
Any update? |
@Gp2mv3 I had a some problem and I added below line to my test. It works now.
But still is a only workaround. @marshallshen's solution is better because replace depracated ListView |
++ issue, update please |
This should be merged to make the package usable. |
Background
The original problem is caused by RN deprecating
ListView
in favor ofFlatList
, a solution is merged here.However, a better solution IMO is to upgrade
ListView
entirely.Testing
yarn test
result withreact-native-modal-dropdown 0.70
:yarn test
result with the PR fork