Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FooterにSNSへのリンクを追加 #60

Merged
merged 4 commits into from
Dec 1, 2023
Merged

FooterにSNSへのリンクを追加 #60

merged 4 commits into from
Dec 1, 2023

Conversation

oka4shi
Copy link
Member

@oka4shi oka4shi commented Nov 30, 2023

Close: #50

@github-actions GitHub Actions
Copy link

以下のリンクからfeature/add-sns-iconsブランチのプレビューを参照することができます。
コミットが追加されると、プレビューも自動更新されます。

https://feature-add-sns-icons.teaser23.pages.dev/

@oka4shi oka4shi requested review from Ryoga-exe and appare45 and removed request for Ryoga-exe November 30, 2023 10:29
appare45
appare45 approved these changes Nov 30, 2023
View reviewed changes
Copy link
Member

@appare45 appare45 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

大体いいと思います！
コメントつけたけどそんな気にしなくて大丈夫な説もあります

src/components/Footer.astro
>
</li>
</ul>
</section>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

新しいタブで開くと良さそうじゃない？

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ちょっと思ってました。
新しいタブにします。

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Dec 1, 2023 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 27e5023
Status: ✅  Deploy successful!
Preview URL: https://a4465ac1.teaser23.pages.dev
Branch Preview URL: https://feature-add-sns-icons.teaser23.pages.dev

View logs

@Ryoga-exe Ryoga-exe merged commit 4f4d9a6 into develop Dec 1, 2023
1 check passed
@Ryoga-exe Ryoga-exe deleted the feature/add-sns-icons branch December 1, 2023 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@appare45 appare45 appare45 approved these changes

@Ryoga-exe Ryoga-exe Ryoga-exe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SNSへのリンクが欲しいかも
3 participants
@oka4shi @Ryoga-exe @appare45