Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Twitter向けOGタグを整理 #70

Merged
merged 2 commits into from
Dec 4, 2023
Merged

Twitter向けOGタグを整理 #70

merged 2 commits into from
Dec 4, 2023

Conversation

oka4shi
Copy link
Member

@oka4shi oka4shi commented Dec 4, 2023

#67 (comment)

カードの利用開始 | Docs | Twitter Developer Platformの「TwitterカードとOpen Graph」の項にある例を見ると、twitter:imagetwitter:titletwitter:urlは不要で、通常のOGを設定するだけで十分っぽいので修正。

また、twitter:creatorを追加。

@oka4shi oka4shi requested review from Ryoga-exe and appare45 December 4, 2023 03:04
Copy link

github-actions bot commented Dec 4, 2023

以下のリンクからfix/head-twitterブランチのプレビューを参照することができます。
コミットが追加されると、プレビューも自動更新されます。

https://fix-head-twitter.teaser23.pages.dev/

@oka4shi oka4shi mentioned this pull request Dec 4, 2023
@oka4shi oka4shi changed the title 不要なTwitter向けOGタグを削除 Twitter向けOGタグを整理 Dec 4, 2023
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: f6135c6
Status: ✅  Deploy successful!
Preview URL: https://3d51ace5.teaser23.pages.dev
Branch Preview URL: https://fix-head-twitter.teaser23.pages.dev

View logs

Copy link
Member

@appare45 appare45 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Ryoga-exe Ryoga-exe merged commit a450e8c into develop Dec 4, 2023
1 check passed
@appare45 appare45 deleted the fix/head-twitter branch December 4, 2023 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants