Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow ghc-9.10; bump CI #423

Merged
merged 2 commits into from
Jun 2, 2024
Merged

Allow ghc-9.10; bump CI #423

merged 2 commits into from
Jun 2, 2024

Conversation

andreasabel
Copy link
Collaborator

@andreasabel andreasabel commented May 21, 2024

@andreasabel
Copy link
Collaborator Author

CI fails due to setup-haskell broken on macos-14 (and does not partially succeed because of fail-fast: true).

@sol
Copy link
Owner

sol commented May 21, 2024

This is a duplicate of #421.

@andreasabel
Copy link
Collaborator Author

This is a duplicate of #421.

Not in the strong sense, as it also bumps action versions and adds more GHC minor versions to CI.
(Also it allows ghc-9.11 which hasn't been tested.)

Sorry, I should have checked the open PRs first.

One could cherry-pick the additional changes from here to #421 if they are desired...

@sol
Copy link
Owner

sol commented May 22, 2024

This is a duplicate of #421.

Not in the strong sense, as it also bumps action versions and adds more GHC minor versions to CI. (Also it allows ghc-9.11 which hasn't been tested.)

All good points 👍

Sorry, I should have checked the open PRs first.

That's OK, nothing bad happened. I just wanted to make you aware of the effort done by @sellout.

One could cherry-pick the additional changes from here to #421 if they are desired...

I am happy with any PR that reaches a mergable state, either this one or #421.

@sellout
Copy link
Contributor

sellout commented May 22, 2024

Sorry – got busy yesterday. I’ve just replicated the build failure now.

Assuming fixing that goes well (seems trivial), I think this PR could be rebased (or whatever) after #421 is merged. And good point about allowing GHC HEAD to work.

@sol
Copy link
Owner

sol commented May 23, 2024

I think this PR could be rebased (or whatever) after #421 is merged.

Great, sounds good to me.

@sol sol enabled auto-merge (squash) June 2, 2024 11:38
@sol sol merged commit da742f2 into main Jun 2, 2024
47 checks passed
@sol sol deleted the ghc-9.10 branch June 2, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support GHC 9.10
3 participants