-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add basics/close-account/poseidon #161
base: main
Are you sure you want to change the base?
Add basics/close-account/poseidon #161
Conversation
adpthegreat
commented
Oct 20, 2024
•
edited
Loading
edited
- added poseidon close_account program to basics/close-program folder
- updated dependencies to use latest versions of anchor
- used pnpm in place of yarn, , replaced all instances of yarn with pnpm
- wrote solana bankrun tests
- ran pnpm fix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of using u8 for the name field, consider using a String or a fixed-size byte array for more practical usage. Ensure the allocated account space matches the actual size needed for the UserAccount struct. Add logging with msg! to track key actions like account creation and closure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
storing the name as a u8 may limit usability; switching to a string or byte array would be better.
Poseidon does not currently support strings or fixed sized byte arrays so i did that to improvise, i think its best i removed it, also poseidon does not support msg()! macro |
Ohh okay thank you so much for your feedback
…On Tue, 22 Oct 2024 at 5:51 PM, The Maker ***@***.***> wrote:
Poseidon does not currently support strings or fixed sized byte arrays so
i did that to improvise, i think its best i removed it, also poseidon does
not support msg()! macro
—
Reply to this email directly, view it on GitHub
<#161 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AZ6ZEVW5RFJHKJ6KWT7Z3FTZ4Z7A7AVCNFSM6AAAAABQIRQHFSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMRZG44DINRUGE>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
0b89afa
to
8e3abca
Compare