Skip to content

Manually limit bytemuck_derive to ">=1.8.1, <1.9.0" #3609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

cryptopapi997
Copy link
Contributor

bytemuck_derive released a new minor version which requires the rust tooling to use 1.84, which uses the 2024 edition. cargo-sbf is still on 1.79, so it cannot use this. Normally, cargo should only select packages that match it's rust version, but in this case it clearly does not, resulting in any new anchor project being broken. More info in #3606.

Ideally we'd want to resolve this upstream, for which @Tritlo took the initiative with his PR here, however judging by the maintainer's comments in the issue thread, this one is unlikely to be merged.

Opening this PR pre-emptively, but I propose waiting on the upstream PR to be finished (either via merge or close) to then decide on closing or merging this PR.

Copy link

vercel bot commented Mar 19, 2025

@cryptopapi997 is attempting to deploy a commit to the coral-xyz Team on Vercel.

A member of the Team first needs to authorize it.

@Tritlo
Copy link

Tritlo commented Mar 19, 2025

Yeah, the PR has been thoroughly rejected. Silly, to make your package break for no gain at all.

@acheroncrypto acheroncrypto added cli fix Bug fix PR labels Mar 19, 2025
Copy link
Collaborator

@acheroncrypto acheroncrypto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making this PR. However, this would basically only fix the anchor init issues, and the people who just add the anchor-lang crate, or the people who're upgrading from an older version would still run into this issue. That's why it's much better to fix this directly from lang instead of CLI (#3610).

Ideally we'd want to resolve this upstream, for which @Tritlo took the initiative with his PR here, however judging by the maintainer's comments in the issue thread, this one is unlikely to be merged.

I think we'll be able to avoid these issues altogether once build-sbf uses Rust >=1.84: https://blog.rust-lang.org/2025/01/09/Rust-1.84.0.html#cargo-considers-rust-versions-for-dependency-version-selectio

@cryptopapi997 cryptopapi997 deleted the patch-1 branch March 20, 2025 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli fix Bug fix PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants