Feature - Strict ELF parser #624
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lichtso
force-pushed
the
feature/stricter_elf_parser
branch
2 times, most recently
from
095fff9
to
d5a97fc
Compare
Lichtso
commented
Oct 28, 2024
| } else { | ||
| aligned = AlignedMemory::<{ HOST_ALIGN }>::from_slice(bytes); | ||
| aligned.as_slice() | ||
| match e_flags { |
There was a problem hiding this comment.
This mapping will be updated in #602.
Lichtso
force-pushed
the
feature/stricter_elf_parser
branch
3 times, most recently
from
893f914
to
e1fd3c8
Compare
Lichtso
force-pushed
the
feature/stricter_elf_parser
branch
from
e1fd3c8
to
364c6ec
Compare
LucasSte
reviewed
Nov 6, 2024
| let aligned; | ||
| let bytes = if is_memory_aligned(bytes.as_ptr() as usize, HOST_ALIGN) { | ||
| bytes | ||
| let e_flags = LittleEndian::read_u32(bytes.get(48..52).ok_or(ElfParserError::OutOfBounds)?); |
There was a problem hiding this comment.
We could have a comment explaining these hardcoded numbers (48..52).
LucasSte
reviewed
Nov 12, 2024
| types::{Elf64Ehdr, Elf64Shdr, Elf64Sym}, | ||
| }; | ||
|
|
||
| let aligned_memory = AlignedMemory::<{ HOST_ALIGN }>::from_slice(bytes); |
There was a problem hiding this comment.
This is still copying the ELF, ins't it?
There was a problem hiding this comment.
Yes, one is still required because of loader-v3 misalignment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative implementation of #605 for SIMD-0189