Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

math: Add f64 powf and powi #2463

Merged
merged 2 commits into from
Aug 21, 2023
Merged

math: Add f64 powf and powi #2463

merged 2 commits into from
Aug 21, 2023

Conversation

joncinque
Copy link
Contributor

@joncinque joncinque commented Sep 28, 2021

Problem

powf finally works in bpf!

Solution

To make sure it keeps working, here's a test calling powi and powf on floats

@github-actions github-actions bot added the stale [bot only] Added to stale content; will be closed soon label Aug 10, 2023
@github-actions github-actions bot closed this Aug 17, 2023
@joncinque joncinque reopened this Aug 17, 2023
@joncinque
Copy link
Contributor Author

joncinque commented Aug 17, 2023

It might be worth adding this test in if powf is now supported

Edit: it works now! So let's get this in

@github-actions github-actions bot removed the stale [bot only] Added to stale content; will be closed soon label Aug 18, 2023
@joncinque joncinque marked this pull request as ready for review August 21, 2023 12:23
buffalojoec
buffalojoec previously approved these changes Aug 21, 2023
libraries/math/src/processor.rs Outdated Show resolved Hide resolved
@mergify mergify bot dismissed buffalojoec’s stale review August 21, 2023 17:14

Pull request has been modified.

@joncinque joncinque merged commit ec671eb into solana-labs:master Aug 21, 2023
10 checks passed
@joncinque joncinque deleted the powf branch August 21, 2023 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants