-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[token-2022] Update confidential transfer instruction to support split proof contexts #5001
Merged
samkim-crypto
merged 14 commits into
solana-labs:master
from
samkim-crypto:token22-divide-transfer
Aug 18, 2023
Merged
[token-2022] Update confidential transfer instruction to support split proof contexts #5001
samkim-crypto
merged 14 commits into
solana-labs:master
from
samkim-crypto:token22-divide-transfer
Aug 18, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samkim-crypto
force-pushed
the
token22-divide-transfer
branch
5 times, most recently
from
August 14, 2023 23:18
0fca7ce
to
5825be1
Compare
samkim-crypto
force-pushed
the
token22-divide-transfer
branch
from
August 17, 2023 10:13
6d31e9d
to
5018647
Compare
joncinque
approved these changes
Aug 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for breaking up all the commits and explaining each step. Even the really technical stuff was very digestible!
I added a commit to fix the serde tests, so this is good to go!
Thanks for the help @joncinque! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Transfer
is going to be a bit more involved, so I created averify_proof
submodule and refactored the existingverify_..._proof
()` helper functions into this submodule.instruction.rs
modules to support split proof context states. The most notable change here is the addition ofSplitContextStateAccounts
variant ofProofLocation
argument type.verify_..._proof()
helper functions to take in the iterator ofaccount_info
's since functions likeverify_transfer_proof
need to take in variable number of context state accounts.ciphertext_extraction
module should really belong to thesolana-zk-token-sdk
, so they can be removed on a future Solana upgrade.solana-zk-token-sdk
(and hence added tociphertext_extraction
submodule, which could be removed in the future).