Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transfer Hook Docs #5034

Merged
merged 4 commits into from
Aug 16, 2023
Merged

Conversation

buffalojoec
Copy link
Contributor

@buffalojoec buffalojoec commented Aug 15, 2023

This PR updates the documentation for the Transfer Hook Interface and the TLV Account Resolution library

Closes #4942

joncinque
joncinque previously approved these changes Aug 15, 2023
Copy link
Contributor

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some tiny nits, all good after that!

docs/src/token-2022/extensions.mdx Outdated Show resolved Hide resolved
When a user attempts to transfer your token, they might provide to Token-2022:

```rust
[source, mint, destination, owner/delegate]
Copy link
Contributor

@joncinque joncinque Aug 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't something to change in this PR, but this example outlines an issue with the current approach, and makes it clearer that we definitely need the ability to read into account data. Here, you give owner/delegate, but if it's the delegate, then the address won't be the same as with owner

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coooooming right up next!

docs/src/token-2022/extensions.mdx Outdated Show resolved Hide resolved
token/transfer-hook-interface/README.md Outdated Show resolved Hide resolved
@mergify mergify bot dismissed joncinque’s stale review August 16, 2023 00:13

Pull request has been modified.

Copy link
Contributor

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@buffalojoec buffalojoec merged commit e63e718 into solana-labs:master Aug 16, 2023
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update docs for Transfer Hook & TLV Account Resolution
2 participants