-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transfer Hook Docs #5034
Transfer Hook Docs #5034
Conversation
8ed53ed
to
68ec0fa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some tiny nits, all good after that!
docs/src/token-2022/extensions.mdx
Outdated
When a user attempts to transfer your token, they might provide to Token-2022: | ||
|
||
```rust | ||
[source, mint, destination, owner/delegate] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't something to change in this PR, but this example outlines an issue with the current approach, and makes it clearer that we definitely need the ability to read into account data. Here, you give owner/delegate
, but if it's the delegate, then the address won't be the same as with owner
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coooooming right up next!
Pull request has been modified.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job!
This PR updates the documentation for the Transfer Hook Interface and the TLV Account Resolution library
Closes #4942