Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

token-js: added the missing AuthorityTypes and tests #5102

Merged
merged 4 commits into from
Aug 24, 2023

Conversation

wjthieme
Copy link
Contributor

@wjthieme wjthieme commented Aug 24, 2023

resolves #5100

The following tests are still missing since the js-client does not support initializing these extensions yet

  • ConfidentialTransferMint
  • ConfidentialTransferFeeConfig
  • MetadataPointer

Will add a test for TransferHookProgramId once #5096 is merged

@mergify mergify bot added the community Community contribution label Aug 24, 2023
@wjthieme wjthieme marked this pull request as draft August 24, 2023 13:43
@wjthieme wjthieme marked this pull request as ready for review August 24, 2023 13:57
Copy link
Contributor

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment, the rest looks perfect!

token/js/test/e2e/setAuthority.test.ts Outdated Show resolved Hide resolved
@joncinque
Copy link
Contributor

Thanks!

@joncinque joncinque merged commit fd775b5 into solana-labs:master Aug 24, 2023
28 checks passed
@wjthieme wjthieme deleted the wjthieme-patch-2 branch August 25, 2023 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Community contribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

token-js: Support all authority types for set-authority
2 participants