token metadata: replace IncorrectMintAuthority with TokenError::OwnerMismatch
#5615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
This was referenced Oct 19, 2023
|
Scrapping this, too. I wanted to share some of these repeated things like functions and errors across interfaces, but I don't think it's worth the trouble. |
buffalojoec
deleted the
10-19-token_metadata_replace_IncorrectMintAuthority_with_TokenError_OwnerMismatch_
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per discussions on #5596, this PR removes the
IncorrectMintAuthorityerror variant fromTokenMetadataErrorand replaces it withTokenError::OwnerMismatchto follow already pre-established patterns, and allow this error handling to be shared across interfaces/extensions such as SPL Token Group.