[token-cli] Add confidential transfer deposit, withdraw, apply pending balance, and confidential transfer #5630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samkim-crypto
force-pushed
the
token-cli/confidential-transfer-deposit-withdraw
branch
from
ae36bf6
to
e8d72bf
Compare
samkim-crypto
force-pushed
the
token-cli/confidential-transfer-deposit-withdraw
branch
from
371613d
to
085f495
Compare
joncinque
reviewed
Oct 24, 2023
| .await | ||
| .unwrap(); // configure destination account for confidential transfers first | ||
|
|
||
| // NOTE: the test fails due to transaction size limit |
There was a problem hiding this comment.
The next step is to add support for split proofs for this to pass, right?
There was a problem hiding this comment.
Yep that would be the next step. Since this PR is quite long already, should we land this PR once the existing issues are addressed and then add the split proofs in a follow-up?
There was a problem hiding this comment.
Yeah that's fine, it'll require #5663 anyway!
|
|
||
| // withdraw confidential tokens | ||
| // | ||
| // NOTE: the test fails due to transaction size limit :( |
There was a problem hiding this comment.
We'll just need another helper on the token client to generate the proof here, right?
There was a problem hiding this comment.
Yeah, it should suffice to build a token-client function that (1) creates a withdraw proof context, and then (2) follow through with the withdraw instruction.
samkim-crypto
changed the title
joncinque
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The token-cli does not yet support confidential transfer instructions to deposit and withdraw confidential transfer tokens, apply pending balance to available balance, and make a confidential transfer.
Summary of changes
Add the four commands for the four instructions listed above. For confidential transfers, the functionality is added into the existing
transfercommand instead of creating a dedicated command for confidential transfers.