[token-cli] sequentially process confidential transfer withdraw in token-cli #5674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joncinque
approved these changes
Oct 27, 2023
Comment on lines
+3444
to
+3453
| // close context state account | ||
| let context_state_authority_pubkey = context_state_authority.pubkey(); | ||
| let close_context_state_signers = &[context_state_authority]; | ||
| token | ||
| .confidential_transfer_close_context_state( | ||
| &context_state_pubkey, | ||
| &token_account_address, | ||
| &context_state_authority_pubkey, | ||
| close_context_state_signers, | ||
| ) |
There was a problem hiding this comment.
Is it possible to do the withdraw and close in the same transaction? If so, it would be good to do it in this PR
There was a problem hiding this comment.
Yes, good idea!
There was a problem hiding this comment.
Added issue #5685, which will be addressed in a follow-up PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We can't do confidential token withdrawal through the cli due to the transaction size limit
Summary of changes
Divide up the process of creating proof context states and the actual token withdraw.