[token-client] Remove proof-program feature in token-client
#5684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samkim-crypto
force-pushed
the
token-client/remove-proof-program-feature
branch
from
221d37d
to
e299bb9
Compare
joncinque
previously approved these changes
Oct 27, 2023
token/client/Cargo.toml
Outdated
| spl-token-2022 = { version = "0.9", path="../program-2022" } | ||
| spl-token-metadata-interface = { version = "0.2", path="../../token-metadata/interface" } | ||
| spl-transfer-hook-interface = { version = "0.3", path="../transfer-hook/interface" } | ||
| spl-associated-token-account = { version = "2.0", path = "../../associated-token-account/program", features = [ |
There was a problem hiding this comment.
It looks like a bunch of unrelated formatting got in too, can you revert those?
samkim-crypto
force-pushed
the
token-client/remove-proof-program-feature
branch
from
e299bb9
to
4696e32
Compare
mergify
bot
dismissed
joncinque’s stale review
Pull request has been modified.
samkim-crypto
force-pushed
the
token-client/remove-proof-program-feature
branch
from
4696e32
to
5734ed1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
proof-programfeature in token-client is not really used for anything and contains outdated code that was not removed when the other functions were updated.Summary of changes
Remove the
proof-programfeature and the containing code.