token 2022: add metadata pointer extension to js @solana/spl-token client #5805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mistersimon
commented
Nov 11, 2023
There was a problem hiding this comment.
Hey @buffalojoec - I broke the metadata pointer extension into a separate PR. Thought it would be easier to review smaller changes.
mistersimon
commented
Nov 11, 2023
buffalojoec
reviewed
Nov 12, 2023
mistersimon
force-pushed
the
token-2022/js-metadatapointer-ext
branch
from
561f2c8 to
9d3e3c7
Compare
Thanks for the kind words @buffalojoec. Addressed most of your comments - wanted to clarify one thing on the enums before changing |
buffalojoec
reviewed
Nov 12, 2023
Made those changes. Let me know if there is anything else! |
buffalojoec
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for the metadata pointer extension
Split out of wider task to add metadata support for ease of review
#5667