Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[token js]: transfer-hook: add account meta de-escalation #5816

Merged
merged 1 commit into from
Nov 14, 2023
Merged

[token js]: transfer-hook: add account meta de-escalation #5816

merged 1 commit into from
Nov 14, 2023

Conversation

buffalojoec
Copy link
Contributor

@buffalojoec buffalojoec commented Nov 13, 2023 •
edited
Loading

This PR adds the deEscalateAccountMeta function in JavaScript, which was
previously missing.

The new function operates exactly the same as its Rust counterpart in
spl-tlv-account-resolution.

Addresses point number 1 in #5686.

@buffalojoec buffalojoec mentioned this pull request Nov 13, 2023
Merged
@buffalojoec Graphite App
Copy link
Contributor Author

buffalojoec commented Nov 13, 2023 •
edited
Loading

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@buffalojoec buffalojoec mentioned this pull request Nov 13, 2023
Merged
@buffalojoec buffalojoec force-pushed the 11-13-_token_js_transfer-hook_add_support_for_account_data_seeds branch from 5df3a9b to 28326ad Compare November 13, 2023 13:07
@buffalojoec buffalojoec force-pushed the 11-13-_token_js_transfer-hook_add_account_meta_de-escalation branch from 9b19249 to 69cb75e Compare November 13, 2023 13:07
@buffalojoec buffalojoec marked this pull request as ready for review November 13, 2023 13:07
joncinque
joncinque previously approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

escalation

@buffalojoec Graphite App
Copy link
Contributor Author

buffalojoec commented Nov 14, 2023 •
edited
Loading

Merge activity

  • Nov 14, 5:57 AM: @buffalojoec started a stack merge that includes this pull request via Graphite.
  • Nov 14, 5:57 AM: Graphite rebased this pull request as part of a merge.
  • Nov 14, 5:58 AM: @buffalojoec merged this pull request with Graphite.

Base automatically changed from 11-13-_token_js_transfer-hook_add_support_for_account_data_seeds to master November 14, 2023 10:57
@buffalojoec buffalojoec force-pushed the 11-13-_token_js_transfer-hook_add_account_meta_de-escalation branch from 69cb75e to 70b6d5f Compare November 14, 2023 10:57
@mergify mergify bot dismissed joncinque’s stale review November 14, 2023 10:58

Pull request has been modified.

@buffalojoec buffalojoec merged commit 1b89c06 into master Nov 14, 2023
25 checks passed
@buffalojoec buffalojoec deleted the 11-13-_token_js_transfer-hook_add_account_meta_de-escalation branch November 14, 2023 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joncinque joncinque joncinque left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@buffalojoec @joncinque