ci: Refactor JS tests to avoid running so often #5841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merging this early so that it can be part of the dependabot runs tomorrow and avoid using all of our runners at once. I'll happily integrate any feedback afterwards! |
2501babe
reviewed
Nov 16, 2023
Comment on lines
+4
to
+29
| pull_request: | ||
| paths: | ||
| - 'libraries/type-length-value/js/**' | ||
| - 'memo/js/**' | ||
| - 'name-service/js/**' | ||
| - 'single-pool/js/**' | ||
| - 'stake-pool/js/**' | ||
| - 'token/js/**' | ||
| - 'token-lending/js/**' | ||
| - 'token-metadata/js/**' | ||
| - 'token-swap/js/**' | ||
| - 'pnpm-lock.yaml' | ||
| - '.github/workflows/pull-request-js.yml' | ||
| push: | ||
| branches: [master] | ||
| paths: | ||
| - 'libraries/type-length-value/js/**' | ||
| - 'memo/js/**' | ||
| - 'single-pool/js/**' | ||
| - 'stake-pool/js/**' | ||
| - 'token/js/**' | ||
| - 'token-lending/js/**' | ||
| - 'token-metadata/js/**' | ||
| - 'token-swap/js/**' | ||
| - 'pnpm-lock.yaml' | ||
| - '.github/workflows/pull-request-js.yml' |
There was a problem hiding this comment.
does this mean that any change to any js lib results in all of them running their tests? seems undesireable
There was a problem hiding this comment.
Currently, yes. Ideally we'd want to add a check in the matrix to only run that job if there's a change to the subdir OR the lockfile, but I haven't been able to find how GH actions exposes that at the step-level. Let me know if you find something!
Thankfully, these take max 10 minutes to run, so it seemed like an ok trade-off for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The JS CI that kicks off for any change to pnpm-lock.yaml triggers essentially everything to run, when very often we just need to make sure that the packages build.
Solution
Refactor the CI jobs a bit:
build:programWhile I was at it, I killed off the fee-specific token-swap JS tests, since they were more annoying than anything else to manage.
Note: Marking this a draft since it might take some time to get things right in CI.