[spl-record] Add Reallocate instruction
#6063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joncinque
reviewed
Jan 5, 2024
record/program/src/instruction.rs
Outdated
Comment on lines
65
to
66
| /// 1. `[signer, writable]` The payer account to fund reallocation | ||
| /// 2. `[]` System program for reallocation funding |
There was a problem hiding this comment.
Rather than passing these accounts in, how about we have the client library top up the account with the new required rent exemption?
There was a problem hiding this comment.
Okay, yes agreed. I removed the lamports logic! Let me know what you think.
samkim-crypto
force-pushed
the
record-realloc
branch
from
c5af5ed
to
be4f527
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The record program is useful when storing arbitrary length data on accounts. However, if the data is too long to fit inside an account, it is not possible to record the data without creating a new account with enough space. It would be nice to be able to reallocate more space to the existing account to store longer record data.
Summary of changes
Add a reallocate instruction. I followed the main logic of the reallocate instruction in the token-2022 program.
This PR builds on top of #6062. Once #6062 is merged, I will rebase to master to remove the first few commits.