token-2022: Refactor StateWithExtensionsMut
functionality into trait
#6329
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
As part of moving token-2022 to
Pod
-style deserialization in #6316, we'll eventually need to make newPodStateWithExtensions*
, in which theBaseState
itself is a Pod type.That's easy for the non-mutable case, since we have
BaseStateWithExtensions
that neatly encompasses all of the functionality on a trait. We don't have a mutable version ofBaseStateWithExtensions
.Solution
Create
BaseStateWithExtensionsMut
. This essentially moves all of the common functionality ofStateWithExtensionsMut
into a trait requiring only two functions:get_tlv_data_mut
: just the mutable verison ofget_tlv_data
inBaseStateWithExtensions
get_account_type_mut
: some way to access the account type part of the slice in a mutable way, so that it can be written to during initializationThis PR contains no functional changes, just moving functionality to the new trait.