Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Governance: Remove legacy CreateGovernance instructions #6335

Merged

Conversation

SebastianBor
Copy link
Contributor

@SebastianBor SebastianBor commented Mar 5, 2024

Summary

Remove legacy instructions to create asset specific governances: CreateProgramGovernance, CreateTokenGovernance and CreateMintGovernance. The instructions are leftovers from the spl-governance inception time when the governance accounts were top level accounts and Realm account didn't exist. The asset specific accounts are no longer required because the generic Governance account can handle all the use cases.

Backward compatibility

The change is backward compatible from the state point of view and all the asset specific Governance accounts created in previous versions are still supported.

Any program or client using the assets specific instructions to create Governance accounts must switch to CreateGovernance instruction and explicitly transfer the relevant authorities to the new Governance.

Further work

There is no concept of governed_account any longer and in a follow up PR the field on Governance account will be renamed to governance_seed to indicate its actual meaning.

@mergify mergify bot added the community Community contribution label Mar 5, 2024
@SebastianBor SebastianBor marked this pull request as ready for review March 5, 2024 15:19
Copy link
Contributor

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@SebastianBor SebastianBor merged commit 6c08071 into master Mar 6, 2024
7 checks passed
@SebastianBor SebastianBor deleted the governance-remove-legacy-create-governance-instructions branch March 6, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Community contribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants