Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libraries/pod]: add PodU128 type #7012

Merged
merged 1 commit into from
Jul 16, 2024
Merged

[libraries/pod]: add PodU128 type #7012

merged 1 commit into from
Jul 16, 2024

Conversation

febo
Copy link
Contributor

@febo febo commented Jul 12, 2024

Problem

Currently there is no equivalent Pod* type for u128, so it is not possible to use u128 fields when the alignment does not match.

Solution

Add a PodU128 type, which provides a flexible Pod type based on a byte array.

@febo febo merged commit 8593a5b into solana-labs:master Jul 16, 2024
8 checks passed
@febo febo deleted the podu128 branch July 16, 2024 08:32
joncinque added a commit to joncinque/solana-program-library that referenced this pull request Aug 27, 2024
#### Problem

The publish step is great, but there's still some manual work to add the
changelog and correct title for the created release.

#### Summary of changes

Use git-cliff to generate the release notes. This comes with a very
simple cliff.toml which will do minimal processing, since we don't
follow conventional commits in the repo.

Here's a test run for the given input:

```
$ git-cliff -c ci/cliff.toml "pod-v0.3.0"..master --include-path "libraries/pod/**" --github-repo "solana-labs/solana-program-library"
```

Output:

```
## What's new

- Publish pod v0.3.2 by @github-actions[bot]
- [token-2022] Upgrade to `zk-sdk` (solana-labs#7148) by @samkim-crypto
- Implement `Default` for `PodOption` (solana-labs#7083) by @joncinque
- Bump to 0.3.1 (solana-labs#7075) by @febo
- Improve `PodOption` type (solana-labs#7076) by @febo
- Add `PodU128` type (solana-labs#7012) by @febo
- Add `PodOption` type (solana-labs#6886) by @febo
- Use `bytemuck_derive` explicitly (solana-labs#6928) by @joncinque
```
joncinque added a commit that referenced this pull request Aug 28, 2024
* CI: Add git-cliff step during publish

#### Problem

The publish step is great, but there's still some manual work to add the
changelog and correct title for the created release.

#### Summary of changes

Use git-cliff to generate the release notes. This comes with a very
simple cliff.toml which will do minimal processing, since we don't
follow conventional commits in the repo.

Here's a test run for the given input:

```
$ git-cliff -c ci/cliff.toml "pod-v0.3.0"..master --include-path "libraries/pod/**" --github-repo "solana-labs/solana-program-library"
```

Output:

```
## What's new

- Publish pod v0.3.2 by @github-actions[bot]
- [token-2022] Upgrade to `zk-sdk` (#7148) by @samkim-crypto
- Implement `Default` for `PodOption` (#7083) by @joncinque
- Bump to 0.3.1 (#7075) by @febo
- Improve `PodOption` type (#7076) by @febo
- Add `PodU128` type (#7012) by @febo
- Add `PodOption` type (#6886) by @febo
- Use `bytemuck_derive` explicitly (#6928) by @joncinque
```

* Don't always run the step

* Make the YAML valid

* Trim each commit line to just the first line
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants