Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump bytemuck_derive from 1.7.0 to 1.7.1 #7156

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 16, 2024

Bumps bytemuck_derive from 1.7.0 to 1.7.1.

Changelog

Sourced from bytemuck_derive's changelog.

1.7.1

  • Soundness Fix: The wrap/peel methods for owned value conversion, added to TransparentWrapper in 1.6, can cause a double-drop if used with types that impl Drop. The fix was simply to add a ManuallyDrop layer around the value before doing the transmute_copy that is used to wrap/peel. While this fix could technically be backported to the 1.6 series, since 1.7 is semver compatible anyway the 1.6 series has simply been yanked.

1.7

  • In response to [Unsafe Code Guidelines Issue #286](rust-lang/unsafe-code-guidelines#286), this version of Bytemuck has a Soundness-Required Breaking Change. This is "allowed" under Rust's backwards-compatibility guidelines, but it's still annoying of course so we're trying to keep the damage minimal.
    • The Reason: It turns out that pointer values should not have been Pod. More specifically, ptr as usize is not the same operation as calling transmute::<_, usize>(ptr).
    • LLVM has yet to fully sort out their story, but until they do, transmuting pointers can cause miscompilations. They may fix things up in the future, but we're not gonna just wait and have broken code in the mean time.
    • The Fix: The breaking change is that the Pod impls for *const T, *mut T, and Option<NonNull<T> are now gated behind the unsound_ptr_pod_impl feature, which is off by default.
    • You are strongly discouraged from using this feature, but if a dependency of yours doesn't work when you upgrade to 1.7 because it relied on pointer casting, then you might wish to temporarily enable the feature just to get that dependency to build. Enabled features are global across all users of a given semver compatible version, so if you enable the feature in your own crate, your dependency will also end up getting the feature too, and then it'll be able to compile.
    • Please move away from using this feature as soon as you can. Consider it to already be deprecated.
    • PR 65

1.6.3

  • Small goof with an errant ;, so PR 69 actually got things working on SPIR-V.

1.6.2

cargo upload goof! ignore this one.

1.6.1

  • DJMcNab did a fix so that the crate can build for SPIR-V PR 67

... (truncated)

Commits
  • faff804 chore: Release bytemuck_derive version 1.7.1
  • 7be8c67 derive changelog
  • bb62be5 Remove "dangling" terminology for zero-sized pointees. (#262)
  • 5eecd33 Make must_cast by-value and by-shared-ref functions const (#261)
  • 243302d Add bytemuck attribute to NoUninit derive (#259)
  • e1baf85 Fix box_bytes_zst test (#260)
  • 20f4a09 chore: Release bytemuck version 1.16.3
  • 9f7161c describe pr 256
  • 291a924 Allow casting between slices of ZSTs and slices of non-ZSTs in all cases. (#256)
  • 758774d chore: Release bytemuck version 1.16.2
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the automerge Merge this pull request automatically once CI and reviews are compelte label Aug 16, 2024
@dependabot dependabot bot force-pushed the dependabot/cargo/bytemuck_derive-1.7.1 branch from 9b2dd63 to 73f8ee1 Compare August 16, 2024 12:49
Bumps [bytemuck_derive](https://github.com/Lokathor/bytemuck) from 1.7.0 to 1.7.1.
- [Changelog](https://github.com/Lokathor/bytemuck/blob/main/changelog.md)
- [Commits](Lokathor/bytemuck@bytemuck_derive-v1.7.0...bytemuck_derive-v1.7.1)

---
updated-dependencies:
- dependency-name: bytemuck_derive
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/cargo/bytemuck_derive-1.7.1 branch from 73f8ee1 to 45d2c62 Compare August 16, 2024 12:51
@joncinque joncinque merged commit 2045009 into master Aug 16, 2024
8 checks passed
@joncinque joncinque deleted the dependabot/cargo/bytemuck_derive-1.7.1 branch August 16, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge this pull request automatically once CI and reviews are compelte
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant