Publish to NPM via workflows #128
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdlaver
reviewed
Jan 9, 2023
sdlaver
reviewed
Jan 9, 2023
sdlaver
reviewed
Jan 9, 2023
sdlaver
requested changes
Jan 10, 2023
| node-version: 18 | ||
| cache: 'pnpm' | ||
|
|
||
| - name: Install dependencies and build 🔧 |
There was a problem hiding this comment.
Can we break out the dependency installation from the build? In particular, I believe we should use the --frozen-lockfile option, per the example linked above. I'm generally uncomfortable with the builders being able to silently update dependencies vs. what was tested by developers on their machines. I'd rather it select dependencies predictably, from the preconfigured lockfile.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #8