Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require at least 4 screenshots or videos #266

Merged
merged 1 commit into from
Apr 26, 2024
Merged

Require at least 4 screenshots or videos #266

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions packages/cli/src/config/PublishDetails.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,11 +137,7 @@ export const loadPublishDetailsWithChecks = async (
)

if (previewMediaFiles.length < 4) {
showMessage(
"Preview media requirements changing in version 0.9.0",
`At least 4 screenshots or videos are required for publishing a new release. Found only ${previewMediaFiles.length}`,
"warning"
)
throw new Error(`At least 4 screenshots or videos are required for publishing a new release. Found only ${previewMediaFiles.length}`)
}

validateLocalizableResources(config);
Expand Down
3 changes: 1 addition & 2 deletions packages/core/src/create/ReleaseCore.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import mime from "mime";
import debugModule from "debug";
import type { MetaplexFile } from "@metaplex-foundation/js";
import { toMetaplexFile } from "@metaplex-foundation/js";
import { Constants, mintNft, truncateAddress } from "../CoreUtils.js";
import { Constants, mintNft } from "../CoreUtils.js";
import * as util from "util";
import { metaplexFileReplacer, validateRelease } from "../validate/CoreValidation.js";
import { imageSize } from "image-size";
Expand All @@ -18,7 +18,6 @@ import type {
Publisher,
Release,
} from "../types.js";
import { str } from "ajv";

const runImgSize = util.promisify(imageSize);
const debug = debugModule("RELEASE");
Expand Down
Loading