Feature/inbound attacks event #821
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
undo changes for testing
…into feature/inbound-attacks-event
…xy-improvements Carriers and ships in custom galaxies
…s-event # Conflicts: # server/services/gameTick.ts # server/services/index.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an event (and notification) for carriers detected moving towards your stars
SERVER
carrier attacking star notification flag stored on star, maybe this needs to move
need someone to review and test discord message, currently just a placeholder (maybe good enough)
carrier.specialist not populated when I get carrier from game.galaxy.carriers so I'm loading it manually, seems weird?
being traded scanning mid tick currently not hooked up to this, you should see event next tick though until it isplease double check the _checkForVisibleAttack logic, I haven't played this game very much 🛩️
is there automated testing for events?
CLIENT
unable to get openPlayerDetailsRequested to workunable to get openCarriersDetailsRequested to workunable to test user notification settings for this event (because no discord integration)
phrasing and design should be definitely reviewed