Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ci): dockerized 🐳 #30

Closed
wants to merge 3 commits into from
Closed

chore(ci): dockerized 🐳 #30

wants to merge 3 commits into from

Conversation

albttx
Copy link

@albttx albttx commented Jan 23, 2023

No description provided.

AndreMiras
AndreMiras reviewed Feb 21, 2023
View reviewed changes
Copy link
Contributor

@AndreMiras AndreMiras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that's a cool PR, but maybe we shouldn't mix concerns since it's already taking time to get reviewed.
How about having a PR that does only the containerization part which is already useful.
And then another one for the rest?

@albttx
Copy link
Author

albttx commented Feb 21, 2023

Of course! sorry it's just the PR is linked to my master branch... which i updated with more needed features

@albttx albttx mentioned this pull request Feb 21, 2023
Open
@albttx
Copy link
Author

albttx commented Feb 21, 2023

moved to #33

@albttx albttx closed this Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndreMiras AndreMiras AndreMiras left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@albttx @AndreMiras @shifty11