-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display accession image #5266
Display accession image #5266
Conversation
@hkmanching Could you please check description of this pull request for the ticket that you requested? (display an image on accession details page by using the first uploaded image of the accession) Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice to have an option to choose an image in the next version.
Sorry for the delay. The description makes sense and I agree with @titima15 about being able to choose the image instead of just using the first image uploaded. Should this be functional now? |
Not yet functional - but we have the release and new docker. Need to update the sites!
cheers
Lukas
…________________________________
From: Heather Manching ***@***.***>
Sent: Friday, January 10, 2025 6:27 PM
To: solgenomics/sgn ***@***.***>
Cc: Lukas A. Mueller ***@***.***>; State change ***@***.***>
Subject: Re: [solgenomics/sgn] Display accession image (PR #5266)
Sorry for the delay. The description makes sense and I agree with @titima15<https://github.com/titima15> about being able to choose the image instead of just using the first image uploaded. Should this be functional now?
—
Reply to this email directly, view it on GitHub<#5266 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAAV7F57VUJRSL7AA6ZTR4T2KBJOPAVCNFSM6AAAAABUVZX7H6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKOBUHAYDSMJZGU>.
You are receiving this because you modified the open/close state.Message ID: ***@***.***>
|
Awesome!
Best,
Heather
*Heather Manching*, Ph.D.
North Carolina State University
Research Associate
BI-OnRamp Breeding Coordinator
***@***.***
*Advanced Out of Office Notice:*
*December 22, 2024 - January 3, 2025 - Vacation*
*January 6-17, 2025 - NCGRC & PAG 2025*
*February 24-28, 2025 - NAPPN 2025*
…On Fri, Jan 10, 2025 at 9:07 PM Lukas Mueller ***@***.***> wrote:
Not yet functional - but we have the release and new docker. Need to
update the sites!
cheers
Lukas
________________________________
From: Heather Manching ***@***.***>
Sent: Friday, January 10, 2025 6:27 PM
To: solgenomics/sgn ***@***.***>
Cc: Lukas A. Mueller ***@***.***>; State change ***@***.***>
Subject: Re: [solgenomics/sgn] Display accession image (PR #5266)
Sorry for the delay. The description makes sense and I agree with
@titima15<https://github.com/titima15> about being able to choose the
image instead of just using the first image uploaded. Should this be
functional now?
—
Reply to this email directly, view it on GitHub<
#5266 (comment)>, or
unsubscribe<
https://github.com/notifications/unsubscribe-auth/AAAV7F57VUJRSL7AA6ZTR4T2KBJOPAVCNFSM6AAAAABUVZX7H6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKOBUHAYDSMJZGU>.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
—
Reply to this email directly, view it on GitHub
<#5266 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACCYSGPWNKLLLI2FCLJEBAT2KCRH7AVCNFSM6AAAAABUVZX7H6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKOBVGA3TGMBSGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Description
Replaces the QR code in the stock details section of accession page with the first uploaded image of the accession. Also adds a button to show and hide the QR code above the image.
#5250
Checklist
/t/data/fixture/patches/
./docs
has been updated./js
to/js/source/legacy
.