Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display accession image #5266

Merged
merged 4 commits into from
Jan 9, 2025
Merged

Display accession image #5266

merged 4 commits into from
Jan 9, 2025

Conversation

bm743
Copy link
Contributor

@bm743 bm743 commented Jan 6, 2025

Description

Replaces the QR code in the stock details section of accession page with the first uploaded image of the accession. Also adds a button to show and hide the QR code above the image.

#5250
Checklist

  • Refactoring only
  • Documentation only
  • Fixture update only
  • Bug fix
    • The relevant issue has been closed.
    • Further work is required.
  • New feature
    • Relevant tests have been created and run.
    • Data was added to the fixture
      • Data was added via a patch in /t/data/fixture/patches/.
    • User-Facing Change
      • The user manual in /docs has been updated.
    • Any new Perl has been documented using perldoc.
    • Any new JavaScript has been documented using JSDoc.
    • Any new legacy JavaScript has been moved from /js to /js/source/legacy.

@afpowell afpowell requested review from nmenda and titima15 January 6, 2025 16:14
@titima15
Copy link
Contributor

titima15 commented Jan 7, 2025

@hkmanching Could you please check description of this pull request for the ticket that you requested? (display an image on accession details page by using the first uploaded image of the accession) Thanks

Copy link
Contributor

@titima15 titima15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to have an option to choose an image in the next version.

@lukasmueller lukasmueller merged commit 2e409b6 into master Jan 9, 2025
3 checks passed
@lukasmueller lukasmueller deleted the display_accession_image branch January 9, 2025 16:23
@hkmanching
Copy link

Sorry for the delay. The description makes sense and I agree with @titima15 about being able to choose the image instead of just using the first image uploaded. Should this be functional now?

@lukasmueller
Copy link
Member

lukasmueller commented Jan 11, 2025 via email

@hkmanching
Copy link

hkmanching commented Jan 11, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants